Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stock BouncyCastle, remove embedded libs, convert to Maven #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ibauersachs
Copy link
Contributor

@ibauersachs ibauersachs commented Jan 15, 2017

Closes #4, closes #5

I can try to create multiple smaller pull requests if necessary, but that will be difficult.

Modifications:

  • BigIntegerCrypto removed: incompatible with BouncyCastle
  • Embedded BouncyCastle removed: code duplication just for BigIntCrypto
  • Embedded Curve25519 removed: in BouncyCastle
  • Mavenization: can create an OSGi bundle automatically, doesn't need embedded jars
  • Eclipse files removed: can be created from Maven
  • Fortuna: embedded from bccontrib to avoid dependency. Uses a wrapper now and allows setting a different random source externally
  • License: all GPL-3+ with classpath exception now

@champtar
Copy link

Hi @ibauersachs,

Haven't read your patch bomb :)
Are you periodically reseeding Fortuna periodically?

@ibauersachs
Copy link
Contributor Author

@champtar No, but it's now possible to externally set a different SecureRandom implementation (before the new ZrtpSecureRandom is first accessed).

@ibauersachs
Copy link
Contributor Author

@champtar Oh, and patch bomb: yes, but if you skip all the deleted files it actually isn't much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update / Use BouncyCastle more
2 participants