-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect time shown for recurring items #44
Comments
It's even weirder for me (in Australia). Up to March 2021 it shows the meeting at 6:30am on Thursday (prob 7:30pm day before in your time). But from April 2021 it jumps back to 9:30am on the Wednesday. |
Correction. The entries that show correctly were individual entries. The recurring entry started in April 2021 and always shows one hour out, displaying as 6.30p whereas the calendar entry is for 19.30. Working from a Nextcloud calendar instead of Google gives correct time. |
Thanks for your comment @simplycomputing. Looks as if you probably see the individual entries correctly, but strange that the recurring entry differs by a larger amount than it does for me. |
Just tested this on my google calendar. I made a recurring test event at 9am and it shows on my website as 10pm - that is 10pm for every month into the future. So I don't think it's a daylight saving issue at all. Seems more like a time zone anomaly. For you it is one hour out, but for me it is 11 hours. |
But if I make a single event at 9am it shows correctly as 9am. So why is recurring treated differently?? |
@counterpoint - what is the time difference compared to UTC where you are? For me, Sydney NSW is 11 hours ahead of Coordinated Universal Time so I suspect the recurring events are not being localised. |
@simplycomputing , you are correct with your assumption that times for recurring events are currently not localized, see also the corresponding thread in the forum. |
@counterpoint , can you provide an ICS file from Nextcloud (without private information) including a recurring event ? |
Here is a google calendar ics. For me it has a recurring event at 12pm on the first day of the month, and a recurring event on 2nd Tuesday of the month at 9am |
My timezone is Sydney, Australia by the way. We are currently in daylight saving. |
That looks good. But note the single test event has now jumped forward to previous day (should be 9am on the Wednesday). |
hm, looking into the ics file shows DTSTART:20211214T220000Z for the single event, |
ok, I see - but, the ics data you sent has the following entrys for that single event:
according to that, the day is tuesday 14th dec, not wednesday 15th dec.
|
Oh dear. This sounds like a nightmare to sort out! Well, if you want to just say that your plugin doesn't handle recurring events I certainly wouldn't blame you. :-) |
so, I have committed my latest improvements to master, which works for my Test cases here. |
ok, can you attach the ics file, please ? |
Here it is. |
well, I also thought about the grav config timezone setting, mine is Europe/Berlin, then I also tried Australia/Sydney: |
hm, that seems ok. |
Yeah. It seems like a mess of complications. Thanks for trying. |
yes, that is the right view - the js debugger is sometimes called Sources. |
The calendar file I have been testing with is publicly available at https://thirskandmalton.greenparty.org.uk/calendar.ics. It displays correctly at https://thirskandmalton.greenparty.org.uk/calendar/ and is served by Nextcloud. |
You can see the Full Calendar display connected to Nextcloud and also connected to Google at https://calendar.bsr.cloud/. Curiously, the results are different. It appears that the recurring entry that is based on a fixed recurring date (Green Drinks on 5th of every month) displays correctly when feed from Nextcloud but not from Google. Whereas the recurring event based on the second Wednesday of each month (T&M GP Monthly Meeting) displays wrong in both. |
@counterpoint , |
Thanks @wernerjoss. It seems that the need for Javascript to produce a pretty calendar is throwing up a lot of issues. I was very disappointed that you closed the issue that the popups cannot be moused over. It's not just a matter of not being able to click on links (although that is certainly desirable), it's that you cannot even copy and paste them. If you are reliant on Javascript libraries, it's probably no help to you, but the PHP libraries used in your iCalendar plugin seem to work fine. I added some code to that plugin to pick out any weblinks in the event description, and also made location into a link to Google maps. And elaborated the display a little. The result can be seen at https://calendar.bsr.cloud/events-ical. It isn't as cute as a calendar, but it is a lot more functional. If the calendar can't be made to (a) show correct times and (b) allow for people to link to further information on events, I'm likely to use the event list for preference. I'll probably add a bit more code to fetch the ICS file dynamically (rather than with cron etc). |
well, the icalendar plugin is just a simple list, not more. |
@wernerjoss Yes, I appreciate it is "just" a simple list. But the purpose of a calendar is for people to see what events are planned, and to gain access to details in a useful way. I'm grateful for your efforts on the time problem, but at present the calendar is unusable as it displays incorrect times. Beyond that, from my point of view, a "simple" list that provides all the details of forthcoming events, including clickable links for online meetings or locations or whatever is a lot more user friendly than a calendar that doesn't provide those features. Yes, I'd use a calendar if one with the ICS Calendar functionality was available. But in its absence, my extended event list meets user requirements better. I will try to fork etc when time permits, although as a novice Grav developer I've yet to figure out whether it ought to work like iCalendar or should create its own template, or whether there are any other alternatives for a plugin. To be generally useful, I guess the styling should be parameterised too. BTW I've added the day of the week to each item now. |
ok, @counterpoint , |
so, finally, I'm back again with some news w.r to this issue, see the updated docs - Timezone issues. |
Fantastic! That is an ideal solution since there seem to be so many variables. I'll test it out when I get a chance. Thanks for all your work on this and Happy New Year! |
This is getting very close, but there is one little bug I found. If I use these settings... I found I can get my calendar perfectly in sync with my Google calendar times. This is now all correct: That's great. But I was testing what happened when I changed the single event setting. It actually affects both single and recurring. So this is the result. You see the single has correctly moved on 2 hours, but also the recurring has moved as well. |
ok, fine to see it is now working for you, too. |
Ah, good. Then it's working perfectly. You just need to clarify that in the docs (and maybe the field name). I think it's an excellent solution! It seemed like a nightmare trying to adjust your code to cater for every calendar and time handling. But this is simple and elegant. |
well, I still think this solution is not ideal, as would be an automatic adjustment, but, at least, I hope it can solve the timezone Problem for most users. |
I'm closing this now as there have been no more comments/reports. |
@wernerjoss, as of now the only support for the hour part is been implemented to this plugin, can this plugin be extended for the minutes too, as I am located in the +5.30 time zone and this plugin is not showing the correct event timing in the calander. |
hi @s1-ranjan - yes, the plugin does currently only support integer hour values for timezone corrections. |
Thanks, @wernerjoss for writing me, I would like to point out for Nepal time zone cause Nepal is having +5:45 hours offset, so it would be better to give a better fix so that this plugin has a better fix for everybody. |
Hi @s1-ranjan , |
Hi @wernerjoss , |
hi @s1-ranjan , |
Hi @wernerjoss, |
hm, strange - I am not sure if I understand right what you mean. |
That was a typo error, "reentering the events in the calendar ?" I mean to say I have to re-enter the calendar events in my nextcloud calendar app and making those fresh entries fixed my issue. |
you are right - all-day recurring events were shifted one day forward. |
Thanks @wernerjoss , I have tested your latest fix and I confirm it's working with all-day recurring events. |
ok - fine, thanks for testing + feedback. |
This can be verified by creating a calendar page and inserting the code:
[fullcalendar icsfile="https://calendar.google.com/calendar/ical/pjb5747j5gn75hs223vms3bfng%40group.calendar.google.com/public/basic.ics"][/fullcalendar]
This is a public calendar that should be accessible anywhere. There is an entry for a meeting at 7.30 pm on the second Wednesday of each month. Up to and including March 2021, it is shown correctly. From April 2021 onwards, it is shown incorrectly as 6.30 pm. This might be to do with the clock change on the last Sunday of March, although the time does not become correct again after the change is reversed on the last Sunday of October.
The text was updated successfully, but these errors were encountered: