Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drum Kit Issues #635

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Drum Kit Issues #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d05f2f
refactor: change value of data-key as event.keyCode was deprecated
solidados Nov 12, 2023
9620b8f
feat: drum kit done
solidados Nov 12, 2023
0a0b948
refactor: minor changes
solidados Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 52 additions & 56 deletions 01 - JavaScript Drum Kit/index-START.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,67 +1,63 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<title>JS Drum Kit</title>
<link rel="stylesheet" href="style.css">
<link rel="icon" href="https://fav.farm/🔥" />
<meta charset="UTF-8">
<title>JS Drum Kit</title>
<link href="style.css" rel="stylesheet">
<link href="https://fav.farm/🔥" rel="icon" />
</head>
<body>


<div class="keys">
<div data-key="65" class="key">
<kbd>A</kbd>
<span class="sound">clap</span>
</div>
<div data-key="83" class="key">
<kbd>S</kbd>
<span class="sound">hihat</span>
</div>
<div data-key="68" class="key">
<kbd>D</kbd>
<span class="sound">kick</span>
</div>
<div data-key="70" class="key">
<kbd>F</kbd>
<span class="sound">openhat</span>
</div>
<div data-key="71" class="key">
<kbd>G</kbd>
<span class="sound">boom</span>
</div>
<div data-key="72" class="key">
<kbd>H</kbd>
<span class="sound">ride</span>
</div>
<div data-key="74" class="key">
<kbd>J</kbd>
<span class="sound">snare</span>
</div>
<div data-key="75" class="key">
<kbd>K</kbd>
<span class="sound">tom</span>
</div>
<div data-key="76" class="key">
<kbd>L</kbd>
<span class="sound">tink</span>
</div>
</div>

<audio data-key="65" src="sounds/clap.wav"></audio>
<audio data-key="83" src="sounds/hihat.wav"></audio>
<audio data-key="68" src="sounds/kick.wav"></audio>
<audio data-key="70" src="sounds/openhat.wav"></audio>
<audio data-key="71" src="sounds/boom.wav"></audio>
<audio data-key="72" src="sounds/ride.wav"></audio>
<audio data-key="74" src="sounds/snare.wav"></audio>
<audio data-key="75" src="sounds/tom.wav"></audio>
<audio data-key="76" src="sounds/tink.wav"></audio>

<script>

</script>
<div class="keys">
<div class="key" data-key="A">
<kbd>A</kbd>
<span class="sound">clap</span>
</div>
<div class="key" data-key="S">
<kbd>S</kbd>
<span class="sound">hihat</span>
</div>
<div class="key" data-key="D">
<kbd>D</kbd>
<span class="sound">kick</span>
</div>
<div class="key" data-key="F">
<kbd>F</kbd>
<span class="sound">openhat</span>
</div>
<div class="key" data-key="G">
<kbd>G</kbd>
<span class="sound">boom</span>
</div>
<div class="key" data-key="H">
<kbd>H</kbd>
<span class="sound">ride</span>
</div>
<div class="key" data-key="J">
<kbd>J</kbd>
<span class="sound">snare</span>
</div>
<div class="key" data-key="K">
<kbd>K</kbd>
<span class="sound">tom</span>
</div>
<div class="key" data-key="L">
<kbd>L</kbd>
<span class="sound">tink</span>
</div>
</div>

<audio data-key="A" src="sounds/clap.wav"></audio>
<audio data-key="S" src="sounds/hihat.wav"></audio>
<audio data-key="D" src="sounds/kick.wav"></audio>
<audio data-key="F" src="sounds/openhat.wav"></audio>
<audio data-key="G" src="sounds/boom.wav"></audio>
<audio data-key="H" src="sounds/ride.wav"></audio>
<audio data-key="J" src="sounds/snare.wav"></audio>
<audio data-key="K" src="sounds/tom.wav"></audio>
<audio data-key="L" src="sounds/tink.wav"></audio>

<script src="script.js"></script>
</body>
</html>
23 changes: 23 additions & 0 deletions 01 - JavaScript Drum Kit/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
function playSound (event) {
const eventKey = event.key.toUpperCase()
const audio = document.querySelector(`audio[data-key=${eventKey}]`)
const key = document.querySelector(`.key[data-key=${eventKey}]`)

if (!audio) return;

audio.currentTime = 0;
audio.play();

key.classList.add('playing');
}

function removeTransition (event) {
return event.propertyName === 'transform'
? this.classList.remove('playing')
: null;
}

const keys = document.querySelectorAll('.key');
keys.forEach((key) => key.addEventListener('transitionend', removeTransition));

window.addEventListener('keydown', playSound)