Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style brackets for html syntax #10

Closed
jacobarriola opened this issue Jul 20, 2016 · 4 comments
Closed

Style brackets for html syntax #10

jacobarriola opened this issue Jul 20, 2016 · 4 comments

Comments

@jacobarriola
Copy link

Hey Wes,

Would love to get the #fff color on the < and > brackets like the Sublime version has. Not sure the best way I can contribute or submit a PR. I've tried editing the less stylesheet w/out any luck.

Thanks!

The atom version 👇
image

The Sublime version 👇
image

@rosston
Copy link
Collaborator

rosston commented Jul 20, 2016

Atom theme maintainer here.

That shouldn't be too hard to do. I just tried removing the .meta.tag selector from the styles. It works great for HTML, but not quite right for XML (see below). It should just be a minor adjustment to make sure the punctuation stays white. I'll take a stab at it soon.
screen shot 2016-07-20 at 09 09 44

@jacobarriola
Copy link
Author

Awesome @rosston - would love to back trace how you've accomplished this as well so that I can help next time. Thanks! 👏

@rosston
Copy link
Collaborator

rosston commented Jul 20, 2016

cmd+alt+i (probably ctrl+alt+i not on a Mac?) will bring up the Chromium web inspector. Hacking on Atom and its packages is (almost) as easy as doing web dev work.

Once you've figured out what changes actually need to be made, you can just check out the code somewhere on your machine, make your changes, and symlink the directory into ~/.atom/packages.

That's the super-quick-and-dirty summary of Atom (theme) hacking. 😃

@rosston
Copy link
Collaborator

rosston commented Jul 23, 2016

Fixed and released in 0.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants