Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: change ES6 classes font color. #103

Closed
gonzamvita opened this issue May 27, 2016 · 9 comments
Closed

Suggestion: change ES6 classes font color. #103

gonzamvita opened this issue May 27, 2016 · 9 comments

Comments

@gonzamvita
Copy link

Hello,

When you declare a new ES6 class the 'class' keyword and the name of the class have both the same text color (see image). It will be cool to change class name to another color (maybe red? :p).

http://i.imgur.com/4iZO4CJ.jpg

Regards!

@wesbos
Copy link
Owner

wesbos commented May 27, 2016

@wesbos
Copy link
Owner

wesbos commented May 27, 2016

I also updated the color of the object keys because they were the same colour as strings

@wesbos
Copy link
Owner

wesbos commented May 27, 2016

done done done - your sublime will update within a few hours

@wesbos wesbos closed this as completed May 27, 2016
@gonzamvita
Copy link
Author

Thanks Boss 👍

@gonzamvita
Copy link
Author

Hmmmmm, I don't know why, but I still see the same colors :(

@zeewebdev
Copy link

Hi, Wes. I see same color in function Expression
var getPrice = function(){
return 5.99;
}
both var and getPrice is displaying yellow color

@nMustaki
Copy link

nMustaki commented Jun 2, 2016

Same issue here as zeewebdev, maybe a priority issue as getPrice is both a function and a variable in this case ?
By the way, what's the font you're using for the screenshots ?
Thanks for Cobalt, it's really great !

@jcberquist
Copy link
Contributor

@wesbos: FYI, in the default JavaScript syntax, class names will have the scope entity.name.class.js in the next dev build (they currently have entity.name.type.class.js).

Also, in that syntax, unquoted object keys do not get the scope string.unquoted.label.js any more. All object keys do get the scope meta.object-literal.key.js so if you want to target unquoted object keys in the default JavaScript syntax you could use meta.object-literal.key.js -string.

@wesbos
Copy link
Owner

wesbos commented Jun 2, 2016

Ah, good to know! confusing stuff - mind submitting a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants