Skip to content

Commit

Permalink
Merge pull request #69 from ngurney/master
Browse files Browse the repository at this point in the history
Update readme to support ESLint popup on VSCode 1.51.1 on MacOS Big Sur
  • Loading branch information
wesbos committed Nov 28, 2020
2 parents 35adb5b + 732f084 commit 846c39c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion readme.md
Expand Up @@ -115,7 +115,7 @@ You should read this entire thing. Serious!
Once you have done one, or both, of the above installs. You probably want your editor to lint and fix for you. Here are the instructions for VS Code:

1. Install the [ESLint package](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint)
2. Now we need to setup some VS Code settings via `Code/File``Preferences``Settings`. It's easier to enter these settings while editing the `settings.json` file, so click the `{}` icon in the top right corner:
2. Now we need to setup some VS Code settings via `Code/File``Preferences``Settings`. It's easier to enter these settings while editing the `settings.json` file, so click the Open (Open Settings) icon in the top right corner:
```js
// These are all my auto-save configs
"editor.formatOnSave": true,
Expand All @@ -136,6 +136,8 @@ Once you have done one, or both, of the above installs. You probably want your e
"prettier.disableLanguages": ["javascript", "javascriptreact"],
```

After attempting to lint your file for the first time, you may need to click on 'ESLint' in the bottom right and select 'Allow Everywhere' in the alert window.

Finally you'll usually need to restart VS code. They say you don't need to, but it's never worked for me until I restart.

## With Create React App
Expand Down

0 comments on commit 846c39c

Please sign in to comment.