Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imprv/auto publish charts in gh pages branch #7

Merged
merged 37 commits into from Apr 4, 2020
Merged

Imprv/auto publish charts in gh pages branch #7

merged 37 commits into from Apr 4, 2020

Conversation

ryu-sato
Copy link
Contributor

@ryu-sato ryu-sato commented Mar 15, 2020

This PR is implementation of #2.

All todos have been completed.

  • prepare GitHub Actions workflow
  • adjust documentation of charts
    • Add "helm repo add" instruction.

Features

  • Save helm packages to gh-pages branch (If you wish to change branch name, you can change by GH_PAGES_BRANCH)
  • Lint all charts where under ./charts directory
  • If you need, Install all charts where under ./charts and run test of each chart (default off)
    • This feature spends few minutes

Prerequired

Create orphan branch and configure GitHub Pages.
(follow https://help.github.com/en/github/working-with-github-pages/creating-a-github-pages-site)

Confirmed to follows

  • When update chart version, new version chart is added to helm repository
  • When add new chart in GitHub repository, successfully new chart is added to helm repository
  • When chart has some syntax errors, action was failed (ref)
  • When chart cannot install successfully, action was failed (ref)
    • This feature is optional

Note

I would recommend not to use helm/chart-testing-action and helm/chart-releaser-action now, because these actions have some bugs in checking charts.


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@ryu-sato
Copy link
Contributor Author

When chart has some syntax errors, action was failed (ref)

Corrected URL of above reference.

@yuki-takei
Copy link
Member

scripts の中身って手で打つことは全く想定してない?
マニュアルでも使うんだったら .github の外に出した方がいいんじゃないかと思う。

そうでなければ大筋問題ないと思います。整然としてるし。

@ryu-sato
Copy link
Contributor Author

scripts の中身って手で打つことは全く想定してない?
マニュアルでも使うんだったら .github の外に出した方がいいんじゃないかと思う。

手で打つことは想定してませんでした。
使えそうなものがないか有れば .github の外に出してみます。

@ryu-sato
Copy link
Contributor Author

scripts の中身って手で打つことは全く想定してない?
マニュアルでも使うんだったら .github の外に出した方がいいんじゃないかと思う。

exec-helm-test.sh はマニュアルでも使えそうだったので misc に移動させ、コマンド単体で使えるように以下の改善を行いました。

  • コマンドオプションを用意
  • kind を既に使っている場合を考慮
    • コマンドインストールをスキップ
    • クラスタ名が競合しにくいようランダムな名前を生成
  • シェル終了時に作業リソースを削除
    • インストールディレクトリを削除
    • クラスタを削除

.github/scripts/install-helm.sh Show resolved Hide resolved
.github/scripts/update-repository.sh Show resolved Hide resolved
.github/scripts/update-repository.sh Outdated Show resolved Hide resolved
.github/scripts/update-repository.sh Outdated Show resolved Hide resolved
misc/exec-helm-test.sh Outdated Show resolved Hide resolved
misc/exec-helm-test.sh Outdated Show resolved Hide resolved
misc/exec-helm-test.sh Outdated Show resolved Hide resolved
misc/exec-helm-test.sh Outdated Show resolved Hide resolved
@ryu-sato ryu-sato requested a review from skomma March 30, 2020 16:03
.github/scripts/install-helm.sh Outdated Show resolved Hide resolved
.github/scripts/update-repository.sh Outdated Show resolved Hide resolved
@ryu-sato ryu-sato requested a review from skomma April 2, 2020 15:08
Copy link
Member

@skomma skomma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ラスト一点! 🙏

.github/workflows/release.yaml Outdated Show resolved Hide resolved
@ryu-sato ryu-sato requested a review from skomma April 3, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants