Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document how to pass in urls with ? / & marks #334

Closed
abubelinha opened this issue Mar 10, 2022 · 5 comments
Closed

document how to pass in urls with ? / & marks #334

abubelinha opened this issue Mar 10, 2022 · 5 comments
Labels
completed Feature or request has been completed documentation Improvements or additions to documentation

Comments

@abubelinha
Copy link

abubelinha commented Mar 10, 2022

Original image url (from IIIF server):
https://merovingio.c2rmf.cnrs.fr/fcgi-bin/iipsrv.fcgi?FIF=PIA03883.pyr.tif&WID=800&CVT=jpeg

I guess this fails because there is a "?" in the original url?
https://images.weserv.nl/?url=merovingio.c2rmf.cnrs.fr/fcgi-bin/iipsrv.fcgi?FIF=PIA03883.pyr.tif&WID=800&CVT=jpeg

// 20220310130335
// https://images.weserv.nl/?url=merovingio.c2rmf.cnrs.fr/fcgi-bin/iipsrv.fcgi?FIF=PIA03883.pyr.tif&WID=800&CVT=jpeg

{
  "status": "error",
  "code": 404,
  "message": "Invalid or unsupported image format. Is it a valid image?"
}

@kleisauke kleisauke added the question Further information is requested label Mar 10, 2022
@kleisauke
Copy link
Member

Users are expected to URL-encode the given URL, or at least ? to %3F and & to %26, for example:
https://images.weserv.nl/?url=merovingio.c2rmf.cnrs.fr/fcgi-bin/iipsrv.fcgi%3FFIF=PIA03883.pyr.tif%26WID=800%26CVT=jpeg

@abubelinha
Copy link
Author

abubelinha commented Mar 10, 2022

Great!!
I was suspecting something like this, but I asked because I couldn't find it in the FAQ/docs. Now I see other similar issues (#220, #175, ...)

I suggest adding it to FAQs or as a note next to the main example in docs.

@kleisauke
Copy link
Member

Indeed, we should probably note this in the docs.

@abubelinha abubelinha changed the title how to pass in urls with question marks documentation: how to pass in urls with ? / & marks Mar 11, 2022
@abubelinha abubelinha changed the title documentation: how to pass in urls with ? / & marks document how to pass in urls with ? / & marks Mar 11, 2022
@abubelinha
Copy link
Author

I edited the title and reopen the issue as a reminder of adding this to docs.
Feel free to close it if you prefer.

@abubelinha abubelinha reopened this Mar 11, 2022
@kleisauke kleisauke added documentation Improvements or additions to documentation and removed question Further information is requested labels Nov 17, 2022
@kleisauke kleisauke added the completed Feature or request has been completed label Mar 23, 2024
@kleisauke
Copy link
Member

Documentation has been updated to note this.
https://wsrv.nl/docs/introduction.html#how-it-works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed Feature or request has been completed documentation Improvements or additions to documentation
Development

No branches or pull requests

2 participants