Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

rewrite of chromedriver download #114

Closed
wants to merge 1 commit into from
Closed

rewrite of chromedriver download #114

wants to merge 1 commit into from

Conversation

alfred-sa
Copy link
Contributor

  • Always pick the latest version of chromedriver
  • rewrited using requests instead of the old urllib package

 - Always pick the latest version of chromedriver
 - rewrited using requests instead of the old urllib package
@weskerfoot
Copy link
Owner

There's a specific way google recommends generating the chromedriver version

I'll have to look over this and see what can be merged from the stuff I was working on. My issue was that in order to find the best version of it, you have to know what version of chrome is installed, and that's tricky to do on windows.

@weskerfoot
Copy link
Owner

I think for now it might be fine to just use the latest on windows, and I can pull from this branch and integrate it into what I was doing maybe

@alfred-sa
Copy link
Contributor Author

Maybe with wmic datafile get Version? Did you try? I can implement it if you want, but I must find a Windows to test it.

@weskerfoot
Copy link
Owner

I can test it in a windows VM soon

@weskerfoot
Copy link
Owner

I've been fairly busy lately but I am going to try and do some work on this soon

@weskerfoot
Copy link
Owner

I've got this working on my other branch. Closing this one.

@weskerfoot weskerfoot closed this Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants