-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better solve performance with lsqr #76
Comments
That's a very small difference. And, I'm puzzled by your use of a sparse solver; the matrix involved is not sparse. |
Those time measurements includes "matrix prep" time which makes up about two thirds of the total run time for solve. When I only measure the LSQR vs LSTSQ statetement then the relative improvement is much greater (9s vs 14s -on another machine). That is IMO substantial. Matrix prep time can also be optimized i believe. I looked into LSQR because I had prior experience (from matlab) where it gave huge performance boosts on other large non-sparse matrix systems. Perhaps there are other iterative methods that are even better.(?) |
Here's a little snippet comparing performance of LSTSQ, LSQR, LSMR: scipy/scipy#11204 For matrices that are 100000x20 and 100000x60 then i get:
|
Closing, see #81 (comment). This can be reopened as needed. |
I get better performance when I use the scipy.sparse.linalg.lsqr iterative solver instead of np.linalg.lstsq.
I get 16.7s vs 19.8s for a test with a big data set.
The text was updated successfully, but these errors were encountered: