Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve failing when conf_int='none' #78

Closed
rsignell-usgs opened this issue Jan 10, 2020 · 0 comments · Fixed by #79
Closed

solve failing when conf_int='none' #78

rsignell-usgs opened this issue Jan 10, 2020 · 0 comments · Fixed by #79

Comments

@rsignell-usgs
Copy link
Contributor

solve is failing when conf_int='none'.

For example, if I try changing conf_int='linear' to conf_int='none' in cell [5] of the utide_uv_example.ipynb notebook, I get:

solve: matrix prep ... solution ... diagnostics ... 
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
<ipython-input-10-359a0567fa71> in <module>
      7              method='ols',
      8              conf_int='none',
----> 9              Rayleigh_min=0.95,)

~/miniconda3/envs/pangeo/lib/python3.7/site-packages/utide/_solve.py in solve(t, u, v, lat, **opts)
    198     compat_opts = _process_opts(opts, v is not None)
    199 
--> 200     coef = _solv1(t, u, v, lat, **compat_opts)
    201 
    202     return coef

~/miniconda3/envs/pangeo/lib/python3.7/site-packages/utide/_solve.py in _solv1(tin, uin, vin, lat, **opts)
    377     # Diagnostics.
    378     if not opt['nodiagn']:
--> 379         coef, indPE = ut_diagn(coef, opt)
    380 
    381     # Re-order constituents.

~/miniconda3/envs/pangeo/lib/python3.7/site-packages/utide/diagnostics.py in ut_diagn(coef, opt)
     15 
     16         SNR = (coef['Lsmaj']**2 + coef['Lsmin']**2) / (
---> 17             (coef['Lsmaj_ci']/1.96)**2 +
     18             (coef['Lsmin_ci']/1.96)**2)
     19 

KeyError: 'Lsmaj_ci'
efiring added a commit to efiring/UTide that referenced this issue Jan 10, 2020
Closes wesleybowman#78.
The smoke-test has been extended to catch this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant