Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre-commit hook and update pre-commits #105

Merged
merged 10 commits into from Apr 13, 2022
Merged

Fix pre-commit hook and update pre-commits #105

merged 10 commits into from Apr 13, 2022

Conversation

ocefpaf
Copy link
Collaborator

@ocefpaf ocefpaf commented Apr 13, 2022 •
edited

@efiring if you agree with us running black here can you review this one and merge it? If not I can revert those commits and remove black formatting.

I'm planning on a new release after this to get #104 in it.

efiring
efiring approved these changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual I don't understand everything, but it seems to work. The changes by the new black version are an improvement.

@efiring efiring merged commit 46a80e2 into wesleybowman:master Apr 13, 2022
@ocefpaf ocefpaf deleted the fix_precommit branch April 14, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ocefpaf @efiring