Is this a bug? #29
Is this a bug? #29
Conversation
| @@ -65,7 +65,8 @@ def fbndavg(P, freq, cfreq=None, fbands=None): | |||
| if fbands is None: | |||
| fbands = freq_bands | |||
|
|
|||
| df = freq[2] - freq[1] | |||
| # FIXME: Assigned to but never used. | |||
There was a problem hiding this comment.
Fix it now--just delete the line with the assignment. Same below. And you may delete the commented-out code lines.
|
What was the example that was crashing? How were you ending up with only two frequencies? I don't see how anything at all will work under those circumstances, even with the unused line removed. If your periodogram yields only two frequencies, you don't have enough samples to calculate anything at all. |
Yep. I was testing corner cases to issue better error messages. Another one that arises is in https://github.com/wesleybowman/UTide/blob/master/utide/robustfit.py#L196 when |
ocefpaf
force-pushed
the
periodogram_bug
branch
from
7e00d47
to
cc33a57
Compare
|
I wonder if I had that in there as some sort of a self check for myself when writing. I am not sure, since it was so long. Nice catch though. |
Hi @wesleybowman and @efiring,
I was unable to run the latest checkout of Utide. It was crashing here (even though
dfis not used in the code):df = freq[2] - freq[1], I believe it should bedf = freq[1] - freq[0](or maybe even betterdf = np.diff(freq)?).