Inference: everything except MC error estimates #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untested. A few other cleanups were made along the way.
Added comment
Added support for building model matrix B with inference.
This changeset includes quite a range of modifications; ideally it might have been broken up into smaller pieces. The data from ut_constants is now run through a new function, convert_unicode_arrays, so that things like the list of constituent names are object arrays of strings with trailing whitespace removed. The new test, test_HNL.py, is presently only a smoke test, but it will be expanded to compare results against the matlab-generated output that is now in tests/data.
Add smoke test for initial work on inference, and make it run.
The inference comparison is commented out because the inference implementation is not yet filling in these fields.
test_HNL compares name, A, and g against matlab UTide output
…nce.py. Added complex coefficient calc to _solve.py
Fixed the calculation of inferred coefficients
Updating local copy with changes
Inference amplitude and phase are complete. Partial error implementation.
|
@ocefpaf Is there anything that can be done about the flood of warnings in the Travis runs? |
|
There is. We can split code from pep8 test, and mark pep8 as allow_failures
in Travis-CI to reduce the noise.
I will fix that soon.
|
|
It looks like most of the warnings are coming from an unnecessary attempt to import mpl_toolkits (though I don't know why is generating warnings), and some other such things unrelated to the code actually being tested. Maybe it is something about the miniconda environment being used. |
|
See #42. We don't need to export the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the work done over the summer in collaboration with two UH grad students, Erin Edkins and Alex Ludert. I believe it provides all support for inferred constituents except for the error estimates using the MC method. It also includes a new set of tests using a real sea-level time series.