avoid generic except #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleybowman
approved these changes
Mar 20, 2018
|
@wesleybowman I'm planning to make a new release, v0.2.2, once this is merged. Is that OK? |
|
Absolutely 👍 |
efiring
requested changes
Mar 20, 2018
|
Would someone give me write access to this repo, please? |
I guess that only @wesleybowman can do that. |
|
Also, this PR illustrates that it would be good to have some minimal (not full PEP8) "must pass" checking: 4 spaces, no trailing whitespace. |
|
@efiring I had sent you an invite awhile back (back when I also added @ocefpaf) Here is the invite link: |
ocefpaf
force-pushed
the
avoid_generic_except
branch
from
43b30b2
to
5ee4ba4
Compare
|
The commit here are in #58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic expect may trigger the second calculation when we should've failed early anyway.