Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize CIs #66

Merged
merged 4 commits into from Apr 15, 2019
Merged

Modernize CIs #66

merged 4 commits into from Apr 15, 2019

Conversation

ocefpaf
Copy link
Collaborator

@ocefpaf ocefpaf commented Mar 25, 2019

@wesleybowman sorry for the huge number of changes in a single PR but they are mostly boilerplate stuff. I'll make a few comments in the PR to help the review.

.appveyor.yml Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
tests/test_uv.py Show resolved Hide resolved
utide/periodogram.py Show resolved Hide resolved
@wesleybowman
Copy link
Owner

sorry for the huge number of changes in a single PR

@ocefpaf no worries mate. I actually consider this a pretty small PR (considering some of the ones I get at work). Give me a day or two for this though. Just got back from a small trip and need a day to recover 😪

@ocefpaf
Copy link
Collaborator Author

ocefpaf commented Mar 26, 2019

I actually consider this a pretty small PR (considering some of the ones I get at work).

😄 I prefer small and with limited context PRs.

Give me a day or two for this though. Just got back from a small trip and need a day to recover.

There is no rush. Thanks!

Copy link
Owner

@wesleybowman wesleybowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.appveyor.yml Outdated
PY: 3.7

init:
- "ECHO %PYTHON_VERSION% %MINICONDA%"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the following in the build:

ECHO is off.

I couldn't find a setting to enable ECHO either, but again, I am new to AppVeyor.

And should this be echo instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows is case insensitive so it does not matter if it is ECHO or echo but yeah, that does not work to debug the env vars :-/

But we don't really need that b/c we have the full output of the packages installed down the log.

@wesleybowman wesleybowman self-requested a review April 15, 2019 13:01
Copy link
Owner

@wesleybowman wesleybowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM. You can merge whenever

EDIT: I think I just remembered that you like others to merge your PRs, is that right? I can merge if you would like (at my work, the author always merges, but I don't care one way or the other)

@ocefpaf
Copy link
Collaborator Author

ocefpaf commented Apr 15, 2019

EDIT: I think I just remembered that you like others to merge your PRs, is that right? I can merge if you would like (at my work, the author always merges, but I don't care one way or the other)

Interesting. Usually I avoid self-merges as much as we can but since you already reviewed and approved I guess it is OK. Thanks! Let's see how this goes on master...

@ocefpaf ocefpaf merged commit 5322b0b into wesleybowman:master Apr 15, 2019
@ocefpaf ocefpaf deleted the modernize_cis branch April 15, 2019 13:07
@ocefpaf
Copy link
Collaborator Author

ocefpaf commented Apr 15, 2019

And here are the dev doc pages: http://wesleybowman.github.io/UTide/dev/

We should have the latest in http://wesleybowman.github.io/UTide and versioned in http://wesleybowman.github.io/UTide/dev/version when we issue a new release.

@wesleybowman
Copy link
Owner

That's awesome @ocefpaf! Thanks for taking the time!

@wesleybowman
Copy link
Owner

@ocefpaf should we do a new release then, to get those pages working?

@ocefpaf
Copy link
Collaborator Author

ocefpaf commented Apr 16, 2019

@ocefpaf should we do a new release then, to get those pages working?

👍

In theory, if the auto-deploy works, all you have to do is to tag a new releases.

@ocefpaf
Copy link
Collaborator Author

ocefpaf commented Apr 16, 2019

@wesleybowman I created a point release in https://github.com/wesleybowman/UTide/releases/tag/v0.2.3 and the package was uploaded successfully as expected, see https://pypi.org/project/UTide.

Also, both the latest and versioned version of the docs are online.

@wesleybowman
Copy link
Owner

@ocefpaf thanks! The pages are successfully working now as well 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants