Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test py38 and py37 #80

Merged
merged 7 commits into from
Jan 15, 2020
Merged

Conversation

ocefpaf
Copy link
Collaborator

@ocefpaf ocefpaf commented Jan 15, 2020

We could keep testing on py36 but I don't think it is worth it.

@efiring
Copy link
Collaborator

efiring commented Jan 15, 2020

We should also drop 2.7.

@ocefpaf
Copy link
Collaborator Author

ocefpaf commented Jan 15, 2020

We should also drop 2.7.

Done! I don't think we have any 2.7 specific code to remove though.

@efiring
Copy link
Collaborator

efiring commented Jan 15, 2020

There are a bunch of "from future import" lines, but they could be removed later, unless you want to sweep them out as part of this PR.

./utide/constituent_selection.py:from __future__ import (absolute_import, division, print_function)
./utide/ellipse_params.py:from __future__ import (absolute_import, division, print_function)
./utide/confidence.py:from __future__ import (absolute_import, division, print_function)
./utide/periodogram.py:from __future__ import (absolute_import, division, print_function)
./utide/diagnostics.py:from __future__ import (absolute_import, division, print_function)
./utide/robustfit.py:from __future__ import (absolute_import, division, print_function)
./utide/__init__.py:from __future__ import (absolute_import, division, print_function)
./utide/_solve.py:from __future__ import (absolute_import, division, print_function)
./utide/_time_conversion.py:from __future__ import (absolute_import, division, print_function)
./utide/_ut_constants.py:from __future__ import (absolute_import, division, print_function)
./utide/harmonics.py:from __future__ import (absolute_import, division, print_function)
./utide/utilities.py:from __future__ import (absolute_import, division, print_function)
./utide/_reconstruct.py:from __future__ import (absolute_import, division, print_function)
./utide/data/mat2npz.py:from __future__ import (absolute_import, division, print_function)
./utide/astronomy.py:from __future__ import (absolute_import, division, print_function)
./tests/test_astron.py:from __future__ import (absolute_import, division, print_function)
./tests/test_solve.py:from __future__ import (absolute_import, division, print_function)
./tests/test_harmonics.py:from __future__ import (absolute_import, division, print_function)
./tests/test_periodogram.py:from __future__ import (absolute_import, division, print_function)
./tests/test_normalize.py:from __future__ import (absolute_import, division, print_function)
./versioneer.py:from __future__ import print_function

@ocefpaf
Copy link
Collaborator Author

ocefpaf commented Jan 15, 2020

Indeed. Fixing those now...

@ocefpaf ocefpaf merged commit 8ebc704 into wesleybowman:master Jan 15, 2020
@ocefpaf ocefpaf deleted the test_py38_and_py37 branch January 15, 2020 20:33
@efiring
Copy link
Collaborator

efiring commented Jan 15, 2020

Thank you, @ocefpaf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants