Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating prod deps #40

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Updating prod deps #40

merged 5 commits into from
Aug 25, 2023

Conversation

wesleytodd
Copy link
Owner

@wesleytodd wesleytodd commented Aug 25, 2023

Updating ajv is a breaking change to the validation in two ways:

  1. We are defaulting strict to false. The error here was confusing, and honestly we probably need a test for that mode
  2. The http response data is changed for errors from dataPath to instancePath

Updating path-to-regexp is interesting because it is out of sync with express@4 which is at 0.1.7. It was always though, and since we haven't gotten any complaints about that so far I guess we should be alright?

As with the changes to the dev deps I think we are alright breaking since we are pre-1.x

@wesleytodd wesleytodd changed the title feat(deps)!: ajv@^8.12.0 Updating prod deps Aug 25, 2023
@wesleytodd wesleytodd merged commit e27219c into main Aug 25, 2023
5 checks passed
@wesleytodd wesleytodd deleted the update-prod-deps branch August 25, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant