feat!: add support for routes passed in as arrays #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enov
approved these changes
Jan 17, 2024
wesleytodd
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Awesome, yeah I remember when I was originally writing this and decided not to support this at the time but I knew it was a gap. I agree that this is a less used feature (even if you look at wider express usage it is relatively low) and that going for perfect is probably not worth it until someone comes asking.
IIRC there is one other pending PR that I have just been too busy to circle back on, but maybe we can get a release prepend with this and that?
|
Ah ok yeah I think i was misremembering that there was something else. Looks like we can merge this then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Express natively supports passing multiple paths into the same function as an array as seen in the file test/_routes.js. This PR adds support for passing multiple paths.
This PR was made under the assumption the array of paths would not include regex expressions, and the code may break if the array of paths has a regex expression in it (as of the creation of this PR). I do not believe this will be a common use case; however, it is still possible.