Bugfixes related to setting of cursor on parent nodes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ursor on parent nodes. Also stopped the click handler being installed on nodes which don't have any children. And cursor set correctly if you start a sub-tree collapsed, with <li class=collapsed>
|
Thanks again Neil. |
wesnolte
added a commit
that referenced
this pull request
Feb 6, 2012
Bugfixes related to setting of cursor on parent nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Wes,
Three fixes related to setting the cursor on nodes:
[1]
When opening/closing a parent node, it was calling addClass(), but it also needs to removeClass() otherwise you ended up with both contracted and expanded classes on a node.
[2] the click handler now doesn't get installed on nodes that don't have any children.
[3] set the contracted class on nodes which have their initial state set with
Neil