Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLI-0135] Warning messages are shown as errors #135

Closed
thewillyhuman opened this issue May 15, 2020 · 0 comments · Fixed by #138
Closed

[SLI-0135] Warning messages are shown as errors #135

thewillyhuman opened this issue May 15, 2020 · 0 comments · Fixed by #138

Comments

@thewillyhuman
Copy link
Member

Introduction

Warning messages are shown as follows:

error[W002]: base has been set but not used
--> ../../test/assets/incorrect_schema_big_schema_2.shexl:10:5
        |
10      | base <google.es>
        |      ^ the base `<google.es>` definition is set but not used

Where says error should say warning.

Proposed solution

This error message is configured here:

s"${Console.YELLOW}error[${ttype.getCode}]: ${Console.RESET}${ttype.getDescription}"

If we change that error message the issue would be fixed.

@weso-bot weso-bot changed the title Warning messages are shown as errors [SLI-0135] Warning messages are shown as errors May 15, 2020
@thewillyhuman thewillyhuman added this to Awaiting review in Triage Board via automation May 16, 2020
thewillyhuman added a commit to thewillyhuman/shex-lite that referenced this issue May 16, 2020
@thewillyhuman thewillyhuman moved this from Awaiting review to Accepted in Triage Board May 16, 2020
@thewillyhuman thewillyhuman linked a pull request May 16, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Triage Board
  
Accepted
Development

Successfully merging a pull request may close this issue.

1 participant