Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shape invocation semantic validation #72

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

thewillyhuman
Copy link
Member

Adds the semantic validation for the shape invocations and its corresponding tests to validate the changes.

@thewillyhuman thewillyhuman linked an issue Apr 7, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #72 into master will increase coverage by 2.78%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   64.40%   67.18%   +2.78%     
==========================================
  Files          12       12              
  Lines         250      256       +6     
  Branches       17       14       -3     
==========================================
+ Hits          161      172      +11     
+ Misses         89       84       -5     
Impacted Files Coverage Δ
src/compiler/ast/constraints.scala 50.00% <ø> (+12.50%) ⬆️
src/compiler/ast/ast.scala 38.88% <100.00%> (+18.30%) ⬆️
...ompiler/internal/symboltable/SymbolHashTable.scala 83.72% <100.00%> (ø)
...le/policy/PassiveAggressiveSymbolTablePolicy.scala 94.11% <100.00%> (ø)
...c/compiler/semantic/InvocationsCheckerWalker.scala 85.71% <100.00%> (+5.71%) ⬆️
src/compiler/ast/statements.scala 25.00% <0.00%> (-31.25%) ⬇️
src/compiler/syntactic/ShExLSyntacticParser.scala 66.12% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb749af...13893d0. Read the comment docs.

@thewillyhuman thewillyhuman merged commit cce8e1e into master Apr 7, 2020
@thewillyhuman thewillyhuman deleted the feature/add-shape-inv-validation branch April 7, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLI-0036] Semanticaly validate a shape invocation
1 participant