NC14 compatibility #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes seem to be required regarding the actual app. I can confirm that it is working flawlessly.
|
@westberliner Can you merge the PR and release a new version on apps.nextcloud.com? |
|
Hi, thx for the pull request. Sry, for the late feedback. I am not quite sure why I dont get any mails from github.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes seem to be required regarding the actual app. I can confirm that it is working flawlessly in 14.0-RC1.
Addresses #30
Now, one thing I can't figure out is a compliance error when doing app:check-code. Apparently the appinfo.xml has some problems, but I compared it to the mail and calendar app and all attributes are valid according to https://apps.nextcloud.com/schema/apps/info.xsd.
They don't have to be in the exact same order right?