Switch from Hound to CodeClimate. #23
Conversation
|
@JFernandezWM to be fair this is a public repo so there are no charges for using Hound. That being said it doesn't really make sense to leave it on hound and its free with CodeClimate as well. 😄 |
|
I'd like to eliminate hound just so we have one less tool in our dev toolchain. One less thing that can go down and disrupt us without any feature sacrifice. |
|
Sure, that makes sense... those 184 issues gave me the willies 😄 |
|
I just updated as well the repo settings to not allow push to master, etc. |
|
OK, I see that most of them were silly issues... ⚾️ |
JFernandezWM
force-pushed
the
18-Switch-from-Hound-to-CodeClimate
branch
from
7175bc4
to
7c4e075
Compare
JFernandezWM
requested review from
cracell,
storres-westernmilling and
josephbridgwaterrowe
| @@ -27,7 +27,7 @@ class NewTicketApplication | |||
| def initialize(hash = {}) | |||
| super | |||
|
|
|||
| @record_type = 'GRNT1' | |||
| @record_type = "GRNT1" | |||
There was a problem hiding this comment.
Under our rules these should be single quotes. I think something went wrong with the rubocop config.
There was a problem hiding this comment.
This file should be right https://github.com/westernmilling/otto/blob/master/.rubocop.yml though it could probably be shortened as I think part of those are defaults now.
Gemfile
Outdated
| @@ -1,5 +1,5 @@ | |||
| # frozen_string_literal: true | |||
| source 'https://rubygems.org' | |||
| source "https://rubygems.org" | |||
There was a problem hiding this comment.
Shouldn't the rule be single quotes? From what I can tell is that your ignoring the rubocop rule to accomodate CodeClimate rather than making CodeClimate follow our standard setup?
Or am I confused?
Switch from Hound to CodeClimate so we can cancel hound.
Needed-by: #23