adjust service settings #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- filter out invalid Django settings from environment - coerce environment string values to Python literals - rename `merge_dicts` function name and arguments - add docstrings - add doctests to docstrings and default pytest call
Comment on lines
+92
to
+103
| if value.lower() == "true": | ||
| d[key] = True | ||
| elif value.lower() == "false": | ||
| d[key] = False | ||
| elif value.lower() == "none": | ||
| d[key] = None | ||
| elif value.isdigit(): | ||
| d[key] = int(value) | ||
| elif value.replace(".", "", 1).isdigit(): | ||
| d[key] = float(value) | ||
| else: | ||
| d[key] = value |
There was a problem hiding this comment.
This is all good, but if feels like a solved problem vs. using environs or one of the many libraries that covers all the things. https://github.com/sloria/environs/blob/master/environs/__init__.py#L343C32-L350
There was a problem hiding this comment.
Yeah, point taken. I was basically just trying to get it working, even if it's a bit quick and dirty. I'll open an issue to track using environs or another similar library.
jefftriplett
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge_dictsfunction name and arguments