Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move relay service docker files within dedicated folder #57

Merged
merged 8 commits into from
Oct 25, 2023
Merged

move relay service docker files within dedicated folder #57

merged 8 commits into from
Oct 25, 2023

Conversation

joshuadavidthomas
Copy link
Member

closes #44

@joshuadavidthomas
Copy link
Member Author

Nits that I'm not totally sure about:

  • should the docker folder live in the src directory alongside the actual package source?
  • is docker the best name for the folder? Should it be service?

jefftriplett
jefftriplett reviewed Oct 24, 2023
View reviewed changes
noxfile.py
session.run("python", "-m", "pytest", "-n", "auto", "--dist", "loadfile")
session.run("python", "-m", "pytest")
Copy link
Contributor

@jefftriplett jefftriplett Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I struggled with this, but nox should technically be enough without the dist options.

@jefftriplett
Copy link
Contributor

Nits that I'm not totally sure about:

  • should the docker folder live in the src directory alongside the actual package source?
  • is docker the best name for the folder? Should it be service?

I personally like dockerfiles/Dockerfile if there is only one service name. Otherwise, dockerfiles/{service_name}/Dockerfile

I also slightly prefer .dockerfiles, but because I never want to see it next to the code files.

@joshuadavidthomas joshuadavidthomas marked this pull request as ready for review October 25, 2023 13:04
jefftriplett
jefftriplett approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@jefftriplett jefftriplett left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joshuadavidthomas joshuadavidthomas merged commit 4d73c0f into main Oct 25, 2023
24 checks passed
@joshuadavidthomas joshuadavidthomas deleted the service-folder branch October 25, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefftriplett jefftriplett jefftriplett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider moving service.py in to a separate folder
2 participants
@joshuadavidthomas @jefftriplett