Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚜 Refactors relay + dj-database-url configuration #59

Merged
merged 4 commits into from
Oct 24, 2023
Merged

🚜 Refactors relay + dj-database-url configuration #59

merged 4 commits into from
Oct 24, 2023

Conversation

jefftriplett
Copy link
Contributor

Fixes #55

This needs more opinions.

joshuadavidthomas
joshuadavidthomas reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@joshuadavidthomas joshuadavidthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a small nit, but I would go for the oneliner in this case:

python -m pip install '.[psycopg,relay]'

jefftriplett
jefftriplett commented Oct 24, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@jefftriplett
Copy link
Contributor Author

It's a small nit, but I would go for the oneliner in this case:

python -m pip install '.[psycopg,relay]'

good nitpick. updated. 👍

@jefftriplett jefftriplett marked this pull request as ready for review October 24, 2023 20:35
joshuadavidthomas
joshuadavidthomas approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@joshuadavidthomas joshuadavidthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jefftriplett jefftriplett merged commit 7e0cec9 into main Oct 24, 2023
24 checks passed
@jefftriplett jefftriplett deleted the 55-docker-dj-database-url-refactor branch October 24, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuadavidthomas joshuadavidthomas joshuadavidthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dj-database-url from project dependencies
2 participants
@jefftriplett @joshuadavidthomas