Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚜 Migrate to environs[django] #68

Merged
merged 2 commits into from
Oct 25, 2023
Merged

🚜 Migrate to environs[django] #68

merged 2 commits into from
Oct 25, 2023

Conversation

jefftriplett
Copy link
Contributor

Fixes #25

joshuadavidthomas
joshuadavidthomas approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@joshuadavidthomas joshuadavidthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. With bringing in environs should the get_user_settings_from_env function at the top of the file be rethought?

@jefftriplett jefftriplett mentioned this pull request Oct 25, 2023
Closed
@jefftriplett jefftriplett merged commit 853d2f3 into main Oct 25, 2023
24 checks passed
@jefftriplett jefftriplett deleted the 25-environs-django branch October 25, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuadavidthomas joshuadavidthomas joshuadavidthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use environs or similar library for configuring Django via environment variables in relay Docker service
2 participants
@jefftriplett @joshuadavidthomas