Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow "there is no opening hours sign" answer to opening hours quest #1076

Closed
matkoniecz opened this issue May 18, 2018 · 11 comments · Fixed by #1118
Closed

allow "there is no opening hours sign" answer to opening hours quest #1076

matkoniecz opened this issue May 18, 2018 · 11 comments · Fixed by #1118
Assignees
Milestone

Comments

@matkoniecz
Copy link
Member

I am happy with walking along street and transcribing opening hours sign, but I am not interested going inside shops/night clubs/etc and asking people about opening hours schedule.

So I implemented this feature in my fork and I would be happy to improve our to standards of SC - currently text is not fitting message box and I want to finish discussion on using mailing list.

Implementation that would be base for PR: matkoniecz@7bfb471

@rugk
Copy link
Contributor

rugk commented May 19, 2018

What should it do of that option is selected?

@matkoniecz
Copy link
Member Author

Hide quest, add tag noting this information,

Places with tagged missing opening hours sign would not appear in this quest. Maybe as bonus one may create separate quest "missing opening hours, requires more research as opening hours sign is missing".

@matkoniecz matkoniecz changed the title allow "there is no opening hours sign" to opening hours quest allow "there is no opening hours sign" answer to opening hours quest May 19, 2018
@westnordost
Copy link
Member

If this tag is going to be accepted, it would be a good improvement to the app if it was used.

You mention a discussion on a mailing list, but I cannot find anything.

@matkoniecz
Copy link
Member Author

@westnordost
Copy link
Member

westnordost commented May 24, 2018

I contributed to the discussion in the wiki (FYI) https://wiki.openstreetmap.org/wiki/Talk:Proposed_features/opening_hours:sign%3Dno

@westnordost
Copy link
Member

By the way, I was meaning to ask: Why Zażółć?

@matkoniecz
Copy link
Member Author

matkoniecz commented Jun 3, 2018

I wanted to ensure that bugs/poor ideas introduced in my fork will not get blamed on StreetComplete.

But maybe I should change it "Zażółć (fork of StreetComplete)"

@westnordost
Copy link
Member

I meant to ask what Zażółć means

@matkoniecz
Copy link
Member Author

"Zażółć" can be translated as "make it yellow".

I had no good idea for name and it is planned as a personal fork used just by me, so I was not thinking long about a name.

@westnordost
Copy link
Member

Did you read https://wiki.openstreetmap.org/wiki/Talk:Proposed_features/opening_hours:sign%3Dno#Use_.2A:signed_rather_than_.2A:sign_.3F ?

I would implement collection_times:signed for the post box quest if you used opening_hours:signed=no here and be glad to merge a PR.

@matkoniecz
Copy link
Member Author

matkoniecz commented Jun 18, 2018

opening_hours:signed=no here and be glad to merge a PR.

OK, I will improve & update my code and submit it as a PR.

EDIT: submitted as #1118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants