Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom style for map #183

Closed
rugk opened this issue May 4, 2017 · 21 comments
Closed

Custom style for map #183

rugk opened this issue May 4, 2017 · 21 comments

Comments

@rugk
Copy link
Contributor

rugk commented May 4, 2017

From the screenshots of your used lib I see it also supports showing the height of buildings in a 3d view, so why not use that?

@westnordost
Copy link
Member

westnordost commented May 4, 2017

No reason other than time. At the moment, I am using a standard stylesheet. To create a custom stylesheet is very powerful, you can style any part of the map, even with shaders (have you seen the tron stylesheet on their website?). But it is a lot of work. The detailed stylesheets are about 4000 lines of code.

There are some cool things that can be done when this app has its own stylesheet, 3d buildings is one of them. But at the moment, I do not want to begin this undertaking as there are more pressing things to do.
If you are interested, you could play around, learn how to create those stylesheets and contribute this to this project.

@westnordost
Copy link
Member

westnordost commented May 4, 2017

Actually, a StreetComplete related stylesheet could probably be much simpler than 4k lines of code as many things are not necessary at all

  • no POIs are shown on the SC map
  • no elements are shown that have no relation to the quests
  • only things need to be shown that matter on the survey (on foot), i.e. colored distinctions between different roads (major, minor,...) are not necessary
  • low zoom levels (i.e. zoom < 12 or similar) don't matter / can be disabled

So it might not be that much work.

Are you interested? (or anyone else who is reading this)

I am aiming for a very clear and clean map where - as said - only those things are visible which help the specific use case of this app. See i.e. Pokemon Go, very simplistic. Regarding the color scheme, I was thinking that it should not be "shades of gray" but something with a little more colors as well. Again, Pokemon Go does this very good, but personally I like the colors used in the Tron stylesheet. Though, certainly something to experiment.

Start Experimenting Here

@rugk rugk changed the title 3d view Custom style for map: 3d view May 5, 2017
@rugk
Copy link
Contributor Author

rugk commented May 5, 2017

That's interesting. I think the Tron style is only useful for a "night/dark/black mode" of the app, as it should be light by default, but are not there some other nice templates you can use?
Of course one can also design a custom style, but actually I already liked the left style in their screenshot very much, so maybe you can get a style for it.

@HolgerJeromin
Copy link
Contributor

It would be very helpful to have housenumbers shown. Without a good GPS it is difficult to orientate.

@rugk
Copy link
Contributor Author

rugk commented May 7, 2017

I think that's tracked in #162.

@HolgerJeromin
Copy link
Contributor

Thanks!

@ENT8R
Copy link
Contributor

ENT8R commented Oct 26, 2017

I played a little bit around and created a custom stylesheet! You can look at it here: https://mapzen.com/tangram/view/?api=64617/1161 It looks very similar to Pokemon Go and has only about 200 lines of code. It can also be very easily extended. It would be great if you tell me what you think about it!

@matkoniecz
Copy link
Member

I have my own style. It is unfinished - in part because I wait for mapzen deploying my changes - but it may be usable (after removing some unwanted features, like displaying bicycle parkings) and almost certainly it is a better base than 4k cinnabar mammoth.

https://github.com/matkoniecz/Zazolc/blob/fork/app/src/main/assets/my-style.yaml

@matkoniecz
Copy link
Member

low zoom levels (i.e. zoom < 12 or similar) don't matter / can be disabled

I would not go so far. Sometimes GPS is unavailable or extremely stupid, so ability to move to a correct country is useful. Sometimes it is also useful to download on WiFi locations that are far, far away.

@matkoniecz
Copy link
Member

matkoniecz commented Oct 26, 2017

@ENT8R

I played a little bit around and created a custom stylesheet!

Can you link also style itself?

@ENT8R
Copy link
Contributor

ENT8R commented Oct 26, 2017

Here is the link: https://gist.github.com/ENT8R/0a8c03d896eb75d4729133d300b0db41

@westnordost
Copy link
Member

@ENT8R, I really like what you did there. You both made it look very simple and also tried to copy the playful color theme of Pokemon Go (I guess?) but also already included information that is helpful for StreetComplete users, the housenumbers - and these, quite prominently. If the actual code is as simple as the style looks, then it is a very good starting point for a custom style.

I know that at least @matkoniecz and @Teester already played around a bit but I was not aware of any outcome. Mateusz's seems to have tackled the custom style from the other end: Dumbing down the default (cinnabar) style and keep what may be useful for StreetComplete (users).

Perhaps @ENT8R could create an own repository that links directly to a tangram play page for trying it out and invite people who are interested in contributing to the style there so that not everyone does their own thing but everyone can work together. I think this is better than me governing over PRs because obviously I will not be the (main) developer of a custom SC stylesheet, at least not while it is in development.

@westnordost
Copy link
Member

@rugk did a similar thing when he took care of collecting the metadata for the orchard-produce quest.

@matkoniecz
Copy link
Member

matkoniecz commented Oct 26, 2017

I know that at least @matkoniecz and @Teester already played around a bit but I was not aware of any outcome

My style may be viewed at https://mapzen.com/tangram/view/?api=53844/1164#17.19025/50.07410/19.93505 (slightly simplified version of https://github.com/matkoniecz/Zazolc/blob/fork/app/src/main/assets/my-style.yaml )

@ENT8R
Copy link
Contributor

ENT8R commented Oct 26, 2017

Perhaps @ENT8R could create an own repository that links directly to a tangram play page

Yes I can do that! I will do that tomorrow

@matkoniecz
Copy link
Member

matkoniecz commented Oct 26, 2017

playful color theme of Pokemon Go

Maybe it is just me but this colour scheme is really straining my eyes.


@ENT8R It may be a good idea to document what is missing by design (like POIs). For example, maybe some things that I personally think that are missing are omitted deliberately?

From quick look it would include: barriers (fences, hedges, railway tracks) and labels (for street names and water features), rendering rivers/streams mapped only as lines, smarter labels (displaying labels of major cities larger than ones for tiny villages), better outline handling (see any crossing of major and minor road or a bridge).

@ENT8R
Copy link
Contributor

ENT8R commented Oct 26, 2017

Yes, I think we can track it in the issue tracker of the new repository.

@ENT8R
Copy link
Contributor

ENT8R commented Oct 27, 2017

I created a new repository at https://github.com/ENT8R/streetcomplete-mapstyle
Feel free to contribute!

@matkoniecz
Copy link
Member

I posted some issues, after appearance of license file and sign that copying some features from my style is considered as a good idea I will make PRs.

@wambacher
Copy link

any news about official or private stylesheets?
would like to see landuse in('residential','commercial','retail' and 'industrial') all with the same color to see the difference to e.g. farmland. At the moment all have the same color, so i can't see what's "inside" a city and what's "outside"

@ENT8R
Copy link
Contributor

ENT8R commented Dec 4, 2017

@wambacher we are working on it. Have you seen the repository at https://github.com/ENT8R/streetcomplete-mapstyle ? There you can see the progress of the map and open an issue for your problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants