-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit metadata for South Korea #1327
Conversation
The orchard data is actually generated from official UN data about planted areas of different crops. (See the leading comment on the file.) So what makes you change that data/think, that the data is wrong? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding crops, see rugk, please do not change it.
Regarding sports: What is the source? If it is just personal experience, I cannot accept it. I would accept it if it was based on a source like for example https://en.m.wikipedia.org/wiki/Sport_in_South_Korea and the link is given as a comment in the file.
Unfortunately, I can no longer read the link because of paywall. |
That's unfortunate. I wouldn't like to cite sources that are behind a paywall. I also searched a bit about popular sports in Korea now but found nothing substantial except for that Wikipedia article - which does not really guarantee that the sports mentioned in the article are ordered by popularity. So, I remembered how I did the research for
|
@@ -33,7 +33,7 @@ IE: [gaelic_games, rugby] | |||
IN: [tennis, basketball, soccer, cricket, field_hockey] | |||
JP: [tennis, baseball] | |||
KE: [golf, soccer, tennis, basketball, cricket] | |||
KR: [baseball, badminton, archery] | |||
KR: [baseball, soccer, golf, basketball, badminton] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KR: [baseball, soccer, golf, basketball, badminton] | |
KR: [soccer, tennis, basketball, baseball, golf, badminton, volleyball, archery] |
Based on my previous comment, I suggest this. So, the first two rows are filled with it. I left out skateboard, because skate parks are likely to be already tagged with sport=skateboard so there are less non-tagged pitches which will be "pitches for skateboards".
I understood your intention, and think it is very logical. Then these edits aren't likely to be needed. Thanks! |
I think this metadata will be useful for South Korea than previous metadata.
Thank you in advance!