Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit metadata for South Korea #1327

Closed
wants to merge 2 commits into from
Closed

Conversation

depth221
Copy link

@depth221 depth221 commented Feb 2, 2019

I think this metadata will be useful for South Korea than previous metadata.
Thank you in advance!

@rugk
Copy link
Contributor

rugk commented Feb 2, 2019

The orchard data is actually generated from official UN data about planted areas of different crops. (See the leading comment on the file.) So what makes you change that data/think, that the data is wrong?

Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding crops, see rugk, please do not change it.

Regarding sports: What is the source? If it is just personal experience, I cannot accept it. I would accept it if it was based on a source like for example https://en.m.wikipedia.org/wiki/Sport_in_South_Korea and the link is given as a comment in the file.

@depth221
Copy link
Author

depth221 commented Feb 2, 2019

Then, how about editing the popular sports as "baseball, soccer, golf, basketball, and badminton" based on this like? this link are used in the Wikipedia article as reference.

@depth221
Copy link
Author

depth221 commented Feb 2, 2019

Unfortunately, I can no longer read the link because of paywall.

@westnordost
Copy link
Member

westnordost commented Feb 2, 2019

That's unfortunate. I wouldn't like to cite sources that are behind a paywall. I also searched a bit about popular sports in Korea now but found nothing substantial except for that Wikipedia article - which does not really guarantee that the sports mentioned in the article are ordered by popularity.

So, I remembered how I did the research for popularSports.yml in the first place:

  1. I looked up in Wikipedia etc. what sports are specifically more popular in this country than other countries - so, which sports should be sorted up in any case. E.g. for Korea, it would be archery
  2. I wrote a python script that outputs the number of pitches for each sport, tagged in that country. It is in /tools/. (Currently) the first 10 lines it outputs are:
1594    tennis
1417    soccer
1106    basketball
223     golf
198     baseball
123     badminton
85      skateboard
74      volleyball
54      multi
13      archery
  1. I kinda mashed the info from the two together: If an item would be otherwise pretty much down the list, I put it into popularSports.yml so that it is sorted far up. This is why I ended up with baseball, badminton, archery - because otherwise they would appear much later in the list. (The exact order, if now soccer is before baseball or whatever is really not that important - it is just important that a user in a specific country doesn't have to scroll down all the way all the time)

@@ -33,7 +33,7 @@ IE: [gaelic_games, rugby]
IN: [tennis, basketball, soccer, cricket, field_hockey]
JP: [tennis, baseball]
KE: [golf, soccer, tennis, basketball, cricket]
KR: [baseball, badminton, archery]
KR: [baseball, soccer, golf, basketball, badminton]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
KR: [baseball, soccer, golf, basketball, badminton]
KR: [soccer, tennis, basketball, baseball, golf, badminton, volleyball, archery]

Based on my previous comment, I suggest this. So, the first two rows are filled with it. I left out skateboard, because skate parks are likely to be already tagged with sport=skateboard so there are less non-tagged pitches which will be "pitches for skateboards".

@depth221
Copy link
Author

depth221 commented Feb 3, 2019

I understood your intention, and think it is very logical. Then these edits aren't likely to be needed. Thanks!

@depth221 depth221 closed this Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants