New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail on Ubuntu 16.04 and above #78
Comments
This commit adjusts the thresholds in two tests regarding the mexican hat calculation functionality. It increases the thressholds from the value of `0.028` to `0.033`. The same two tests are failing for Debian Stretch with ruby 2.3.3 and for Debian Buster with ruby 2.5.5. There is also a github issue regarding these same tests for Ubuntu 16.04[1] It seems that this issue is a floating point issue but somewhat related to the OS, because linux trusty specs[2] pass whereas the specs for linux xenial[3] do not and the code has not changed. See also here[4], where the thresholds for these same tests have been modified by the original authors without justifying the change. [1]: westonplatter#78 [2]: https://travis-ci.org/github/MatzFan/phashion/jobs/531359477 [3]: https://travis-ci.org/github/MatzFan/phashion/jobs/531367883 [4]: b6f3a77
@MatzFan thanks for seeing this and making the adjustments. This looks like the right move, especially since there have been no changes to the ruby or underlying C library. Merging :) |
@MatzFan thanks for demonstrating the resolve code changes. I copied your same approach in #88. Would you have any interest in helping maintain phashion and release new versions? I don't spend much time in the ruby world anymore so digging in the details here is harder for me. If you're interested, let's talk. |
@westonplatter happy to give it a go, so long as I don't need to go near the C library! Not used phashion since my attempt to crack Google's reCAPTCHA a few years ago. I still have millions of pHashes of street signs somewhere.. |
@MatzFan added you as a repo collaborator. |
Given the CI is running successfully on ubunut-22.04, I think I can close this out. @MatzFan does closing this issue make sense to you? |
@westonplatter agreed. |
I installed from
master
, complied and ran the tests on my local system (Ubuntu Bionic 18.04). The following is the relevant part of the result:My fork using Travis-CI Xenial (16.04) produces the same result, as you can see here. I have not checked whether whatever causes this affects the fingerprint calculation as well as mh_hash.
Library versions (my local machine):
libpng-dev 1.6.34
libjpeg-dev 8c
The text was updated successfully, but these errors were encountered: