Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for Code block already being registered in Gutenberg 8.3 #117

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Account for Code block already being registered in Gutenberg 8.3 #117

merged 1 commit into from
Jun 22, 2020

Conversation

westonruter
Copy link
Owner

Fixes #116.

@westonruter westonruter mentioned this pull request Jun 21, 2020
Closed
ocean90
ocean90 approved these changes Jun 21, 2020
View reviewed changes
Copy link

@ocean90 ocean90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the notices are gone. 👍

@westonruter westonruter merged commit a1724cd into develop Jun 22, 2020
@westonruter westonruter deleted the fix/gutenberg-8.3-compat branch June 22, 2020 03:30
@grgar grgar mentioned this pull request Jun 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocean90 ocean90 ocean90 approved these changes

@allejo allejo allejo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP notices for undefined index for highlightedLines and showLineNumbers with Gutenberg plugin
3 participants
@westonruter @ocean90 @allejo