Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for w_ipa run_calculation and reading filenames from h5 file #147

Merged
merged 13 commits into from
Mar 26, 2021

Conversation

SHZ66
Copy link
Contributor

@SHZ66 SHZ66 commented Feb 22, 2021

Issue Number. Is this pull request related to any outstanding issues? If so, list the issue number.

Describe the changes made. A clear and concise description of what the problem is and what you did to fix it. E.g. [...] was happening and I've changed [...] to fix it.

Goals and Outstanding Issues. A clear and concise list of goals (to be) accomplished.

  • Fixed a bug where bytes is not properly converted into strwhen reading filenames for basis state files from west.h5.
  • FIxed a bug where bootstrapping length is inaccurately calculated causing w_ipa to crash. Note that bootstrap_length is only useful for logging purposes so this change would not lead to any actual result changes.

Major files changed.

  • Please see file changed section.

Status.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Additional context. Add any other context or screenshots about the pull request here.

Changed based on review.

Co-authored-by: Jeremy Leung <63817169+jeremyleung521@users.noreply.github.com>
@jeremyleung521 jeremyleung521 merged commit f1df2b5 into westpa:westpa-2.0-restruct Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants