-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NumPy2 support fix #374
base: develop
Are you sure you want to change the base?
NumPy2 support fix #374
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #374 +/- ##
========================================
Coverage 41.92% 41.92%
========================================
Files 131 131
Lines 17009 17009
========================================
Hits 7131 7131
Misses 9878 9878
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after those new commits. However, we might actually hold this until the numpy 2.0 release candidate is released (Feb 1st, 2024 Week 2 or 3 of Feb ???) as more breaking changes might arise (as per this thread).
Issue Number. Is this pull request related to any outstanding issues? If so, list the issue number.
Fixes #372
Describe the changes made. A clear and concise description of what the problem is and what you did to fix it. E.g. [...] was happening and I've changed [...] to fix it.
Ran ruff to support numpy2
There are no instances of NPY201 errors found7 instances of NPY201 errors found, easily fixed.There are unrelated unfixed errors below:
All tests passed when numpy commit 539dafa was installed
Goals and Outstanding Issues. A clear and concise list of goals (to be) accomplished.
Major files changed.
Status.
Additional context. Add any other context or screenshots about the pull request here.