ClientExceptions always have a response.

westy92 · Dec 29, 2022 · f749221 · f749221
1 parent ec11dde
commit f749221
Showing 1 changed file with 12 additions and 16 deletions.
diff --git a/src/Client.php b/src/Client.php
@@ -134,22 +134,18 @@ private function request(string $path, array $query, string $type): Model\Standa
 
             return $result;
         } catch (ClientException $e) {
-            if ($e->hasResponse()) {
-                /**
-                 * @var mixed
-                 */
-                $json = json_decode($e->getResponse()->getBody()->__toString(), true);
-                /**
-                 * @var ?string
-                 */
-                $error = is_array($json) && isset($json['error']) && is_string($json['error']) ? $json['error'] : null;
-                throw new \RuntimeException($error
-                    ?? $e->getResponse()->getReasonPhrase()
-                    ?: strval($e->getResponse()->getStatusCode())
-                );
-            } else {
-                throw new \RuntimeException('Unable to parse response.');
-            }
+            /**
+             * @var mixed
+             */
+            $json = json_decode($e->getResponse()->getBody()->__toString(), true);
+            /**
+             * @var ?string
+             */
+            $error = is_array($json) && isset($json['error']) && is_string($json['error']) ? $json['error'] : null;
+            throw new \RuntimeException($error
+                ?? $e->getResponse()->getReasonPhrase()
+                ?: strval($e->getResponse()->getStatusCode())
+            );
         } catch (NotEncodableValueException) {
             throw new \RuntimeException('Unable to parse response.');
         }