Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #1305: remove pull right classes and update ministerial template #1365

Merged

Conversation

neilmispelaar
Copy link
Contributor

This pull request when added addresses two items identified in Issue #1305 :

  1. Remove the remaining clr-rght-md and clr-rght-lg
  2. Fixing this content block: where column is not child of a row

In addition:

  1. The Ministerial profile page templates were brought more in line with how they appear in the Content and IA Spec version 1.5.

Notes:

  1. I had to change the pattern of the Date and Time text in the News section (line 52 of the English Ministerial hbs file) to be an actual time 2018-06-05 19:00 because the html linter did not like the pattern YYYY-MM-DD hh:mm inside a time tag.

@neilmispelaar
Copy link
Contributor Author

I think I did something wrong: the build failed on Travis CI...

@EricDunsworth
Copy link
Member

@neilmispelaar FYI I just manually restarted the Travis-CI build. Looks like it randomly failed to initialize. It didn't get far enough to process any of the files you modified in this PR.

@duboisp duboisp merged commit f3740d5 into wet-boew:master Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants