Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WET-378 GC Site search bar working example #2223

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

josephdiab
Copy link
Contributor

No description provided.

@josephdiab josephdiab temporarily deployed to github-ci August 3, 2023 15:17 — with GitHub Actions Inactive
@josephdiab josephdiab temporarily deployed to github-ci August 16, 2023 18:05 — with GitHub Actions Inactive
@duboisp duboisp added the Query: Project item Part of a github project label Sep 21, 2023
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have improved how to create those working example page, I would like you to make those little update.

sites/search/search-fr.html Outdated Show resolved Hide resolved
sites/search/search-en.html Outdated Show resolved Hide resolved
sites/search/reports/pre-a11y-1.json Outdated Show resolved Hide resolved
sites/search/reports/pre-a11y-1.json Outdated Show resolved Hide resolved
sites/search/reports/pre-a11y-1.json Outdated Show resolved Hide resolved
sites/search/reports/pre-a11y-1.json Show resolved Hide resolved
sites/search/reports/pre-a11y-1.json Outdated Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the requested change reported on Oct 4 + a few additional change.

Please resolve the conversation after you applied/addressed/fixed the inline change request comment. Thanks

sites/search/search-en.html Show resolved Hide resolved
sites/search/search-fr.html Outdated Show resolved Hide resolved
sites/search/reports/pre-a11y-1.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query: Project item Part of a github project
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

2 participants