Skip to content

Commit

Permalink
Removed aria-pressed from Share widget button, at the request of the …
Browse files Browse the repository at this point in the history
…AWG, to minimze confusion from label changing as well.
  • Loading branch information
Paul Jackson authored and Paul Jackson committed Aug 14, 2012
1 parent d874d09 commit 2d065dc
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion build/grids/css/util-ie-min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion build/grids/css/util-min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion build/js/pe-ap-min.js

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions src/js/workers/share.js
Expand Up @@ -93,7 +93,7 @@
}
});
$popupText = elm.find('.bookmark_popup_text').off('click vclick keydown').wrap('<' + opts.popupTag + ' />');
$popupText.attr('role', 'button').attr('aria-controls', 'bookmark_popup').attr('aria-pressed', 'false').on("click vclick keydown", function (e) {
$popupText.attr('role', 'button').attr('aria-controls', 'bookmark_popup').on("click vclick keydown", function (e) {
if (e.type === "keydown") {
if (!(e.ctrlKey || e.altKey || e.metaKey)) {
if (e.keyCode === 13 || e.keyCode === 32) { // enter or space
Expand Down Expand Up @@ -216,11 +216,11 @@
$popup.trigger("closenofocus");
}
} else if (e.type === "open") { // Open the popup menu an put the focus on the first link
$popupText.attr('aria-pressed', 'true').text(opts.hideText + opts.popupText);
$popupText.text(opts.hideText + opts.popupText);
$popup.attr('aria-hidden', 'false').show();
pe.focus($popup.show().find('li a').first());
} else if (e.type === "close" || e.type === "closenofocus") { // Close the popup menu
$popupText.attr('aria-pressed', 'false').text(opts.popupText);
$popupText.text(opts.popupText);
$popup.attr('aria-hidden', 'true').hide();
if (e.type === "close") {
pe.focus($popupText.first());
Expand Down

0 comments on commit 2d065dc

Please sign in to comment.