Global mega menu fails on click events on narrow displays with new Canada.ca look/feel

[minorOffense]

When using the mega menus on narrow displays the sub menu items throw a javascript error on

wet-boew/src/plugins/wb-focus/focus.js

Line 90 in 1882dd3

( $linkTarget = $( "#" + wb.jqEscape( testHref.substring( 1 ) ) ) ).length !== 0 ) {

You can see the error at https://nrc.canada.ca

What happens is that if testHref is less than 2 characters long you end up with a jQuery selector of just "#" which is invalid in jQuery 3 (jQuery 2 incorrectly returns the main html document element). So the $linkTarget variable assignment causes an error.

Specifically

$( "#" + wb.jqEscape( testHref.substring( 1 ) ) )

Causes the error when wb.jqEscape( testHref.substring( 1 ) ) returns blank.

Instead a check should be made to skip this whole logic block if the testhHref value is just "#"

Patch to come.

[duboisp]

PR merged

FYI - That fix are going to be packaged also with the next GCWeb 5.1 release