New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twitter feed is not loading in IE 11 #8787
Comments
If your talking about https://wet-boew.github.io/v4.0-ci/demos/twitter/twitter-en.html the generated timeline is completely controlled by twitter there would be no way to make it work on IE11. I even tested twitters own website that demos the code and it does not work on IE11 (https://publish.twitter.com/). What I would recommend is on IE11 the spinner (loading icon) should be disabled and maybe an incompatible browser message or hide it. I am just a volunteer on this GitHub project. |
Thanks, will do! |
@duboisp Hey this should also be updated on WET side. Is there already code that detects if it IE? If not should this be coded using |
Until then, we will use: SCRIPT <script> function isIE() { ua = navigator.userAgent; /* MSIE used to detect old browsers and Trident used to newer ones*/ var is_ie = ua.indexOf("MSIE ") > -1 || ua.indexOf("Trident/") > -1; return is_ie; } /* Display a text message */ if (isIE()){ $('#ienotsupportedmessage').text("Your browser does not support the display of the Twitter feed. Please try another browser."); } </script>HTML |
@duboisp @EricDunsworth @GormFrank @StdGit Any ideas on how to address this so it would accessible for users using IE11? Current suggestions:
|
Here my one cent |
The spinning wheel is removed automatically and the link to the Twitter account stays so technically, it is still accessible. Considering that 13% only of our visitors (CAL's website) uses IE, removing this widget from WET does not make sense to us. Why would you penalize 9 people out of 10... I suggest that a script detect the browser type and display a message when using IE. We have other ways to implement it but not every department has this privilege with AEM. Also, the government want to implement a new default browser so IE is pretty much dead. The Twitter feed is a useful tool to communicate with the public and Twitter is not ready to die yet. |
I am not an expert, but when I tested the issue in Firefox the wheel was removed after a moment in ie11 the spinning wheel was running indefinitely ... So the wheel should be removed for sure in ie11. If we remove the wheel in ie11 and everybody has a link, the experience is not the same in all the browsers (Some have a spinning wheel when the network is slow) Remember also that Wet is an open project and it is used outside the government, If Twitter is not supported in ie11, what will happen after the user click the link. (What is it missing or not functional). Finally I have given only my 1 cent, I didn't make a full analysis. I wish you a Merry Christmas |
I can also confirm it runs indefinitely in IE11 the spinner as that is being added by WET and not Twitter. |
Good to know, thanks for sharing. We will use WET 4 for our next website starting in April 2020 so it's good to know any issues in advance. If you are a lucky and you have access to the code. Add this to your page and that should do it: SCRIPT (head or end of body section) HTML (close to the Twitter widget) In terms of accessibility, one more click to access the Twitter account from IE is not the end of the world. |
You should try to incorporate your solution in WET, so it will be done for everyone. |
This is the twitter file that would need to be updated: https://github.com/wet-boew/wet-boew/blob/master/src/plugins/twitter/twitter.js |
I might have some time after the holidays to test it in our new CMS that implements WET4. If the code is successful, I will propose a modification to the twitter.js file and leave a comment here. Thanks. |
Does anyone know where twitter.js is located in the WET 4 folders? I can't find it nor test it. |
If you have a forked copy of the repo it’s in src -> plugins -> twitter -> twitter.js. Production downloads merge all the plugins into wet-beow.js (except for polyfills or 3rd party add-ons). |
Here is a propose update to twitter.js: #8800! |
Yes, there is a property named Regarding the fix, it will be preferable to follow a progressive enhancement design approach where it will be to ensure the alternate solution is available and functional instead of displaying a message saying explicitly the plugin is not supported by that specific old browser. @PierreCorriveau it will be preferable to educate the QA team or/and the content expert to explain them the expected behaviour of the twitter timeline with IE11 which is aligned with the progressive enhancement design approach. Just to note that I didn't reproduced the issue yet. So if the user interface look broken in IE11, like if loading spinning icon remain there, it will be preferable to fix the UI instead keeping the broken UI for IE11 because IE11 is still a supported browser by WET-BOEW. |
It not something that can simply be "fix" as the timeline is generated by Twitter. If Twitter has decided to move past IE11 there is no "fix" for that, but as I mentioned above instead of a timeline you could display a twitter link or social button. Only downside with a social button is the user may not have the best experience on the twitter site since there no longer supporting IE11, but that is also out of WET hands. |
Hi, as anyone experienced any issues with the Twitter feed in IE?
It works well in the other browsers and it was working well in IE before today. According to the Twitter's website, IE is not supported:
Do you guys plan to have a layer on top of that to support it in IE?
Thanks!
The text was updated successfully, but these errors were encountered: