Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WET potential security vulnerabilities #8794

Open
jdoyle19 opened this issue Dec 19, 2019 · 9 comments
Open

WET potential security vulnerabilities #8794

jdoyle19 opened this issue Dec 19, 2019 · 9 comments

Comments

@jdoyle19
Copy link

Hello,

Not sure if the Issues forum is the best place for this, but its where I get sent for Questions/Comments.

As part of the development activities for our department, we leverage the Fortify security software to do vulnerability scans on our solutions. Given we use WET for a number of our applications, in some instances the Fortify solution identifies possible security vulnerabilities in the WET code. While I cannot say these represent legitimate vulnerabilities, we were wondering if the details of these vulnerabilities should be shared back to this community for review and possible remediation. If so, what would be the best process to do so.

Thanks in advance.

@ghost
Copy link

ghost commented Dec 19, 2019

There are some issues that have been open for a while, but have not been completed yet.

Migration to jQuery 3 (WET 4) - #8557

MathJax - #8717

Also MathJax does have a minor update 2.7.4 and a major 3, but the major update is incomplete.

@duboisp @GormFrank @EricDunsworth

I am just a volunteer on this GitHub project.

@duboisp
Copy link
Member

duboisp commented Jan 10, 2020

Feel free to share your list of those vulnerability through this issue. We could work together to assess the legitimacy and proceed with a possible remediation.

@RobJohnston
Copy link
Contributor

RobJohnston commented Jan 11, 2020

While we're on the subject, I'm reading through the TBS publication released yesterday: Guide for Publishing Open Source Code.

A recommended best practice is,

a SECURITY.md file explaining security policy as well as procedures for reporting security vulnerabilities.

EDIT:
This is how I handled the same problem that the OP has: #7350. I posted that I thought there was a vulnerability and then send an e-mail with the details of how to exploit it. It was then patched in #7379.

@EricDunsworth
Copy link
Member

Aren't there hundreds of vulnerabilities of varying levels of severity in WET/GCWeb's build dependencies?

Should be possible to view them all by running npm audit.

@duboisp
Copy link
Member

duboisp commented Jan 28, 2020

Thanks @RobJohnston for the info, I will add the SECURITY.md file to our project.

@jdoyle19 if the vulnerability is too sensible to be posted on github, you can send it to the Principal Publisher for my attention, or you can send it directly to me. You can find my info on gcconnex or you can send me an IM.

@GormFrank
Copy link
Contributor

Thanks @RobJohnston for the info, I will add the SECURITY.md file to our project.

@duboisp Were you planning on adding this file?

Then, @jdoyle19 if you consider this issue completed, feel free to close it

@GarthMartin
Copy link

@RobJohnston I don't see the SECURITY.md file anywhere yet. Was this to be added?

@RobJohnston
Copy link
Contributor

Apparently SECURITY.md hasn't been added yet. I wasn't going to do it... don't know what it should say.

@GarthMartin
Copy link

Apparently SECURITY.md hasn't been added yet. I wasn't going to do it... don't know what it should say.

Sorry @RobJohnston misread the message above. @duboisp looks like you had indicated you would add the file. Any update on that? We have something security related that I need to pass on to you...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants