Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Datatables.net - header tooltip when sorting is disabled #9617

Open
DBlaisAsc opened this issue Jun 21, 2023 · 6 comments
Open

[BUG] Datatables.net - header tooltip when sorting is disabled #9617

DBlaisAsc opened this issue Jun 21, 2023 · 6 comments

Comments

@DBlaisAsc
Copy link

Hi

On a datatables.net grid, I disable sort on some columns, but the tooltip generated by the wet still add " : activate for ascending sort" to the column header tooltip. This give a strange behavior.

Regards

@ghost
Copy link

ghost commented Jun 21, 2023

Can you provide a code sample such as some html and js your using?

I am just a volunteer on this GitHub project.

@DBlaisAsc
Copy link
Author

Hi

You can reproduce the issue with that simple example :

<section>
    <div class="table-responsive">
        <table id="SearchGrid" class="wb-tables table table-striped">
            <thead>
                <tr>
                    <th><i class="fas fa-folder"></i><span class="wb-inv">Detail</span></th>
                    <th><i class="fas fa-th-list"></i><span class="wb-inv">Saved list</span></th>
                    <th>Description</th>
                </tr>
            </thead>
        </table>
    </div>
</section>

<script type="text/javascript">

    window["wb-tables"] = {
        dom: "iltrp",
        columns: [
            {
                orderable: false,
                defaultContent: ""
            },
            {
                defaultContent: "",
                orderable: false
            },
            {
                name: "Description",
                data: "Description"
            }
        ],
        data: [
            { Description: "line1" },
            { Description: "line2" }
        ],
        order: [[2, 'asc']]
    };
</script>

@wewhite
Copy link
Contributor

wewhite commented Jun 22, 2023

What version of WET are you using?
Works fine in v4.0.56 -> v4.0.61.1

I cannot test in v4.0.63 as my build environment broke .

@DBlaisAsc
Copy link
Author

I use CDTS v4.0.47, that come with WET v4.0.56.5.

@wewhite
Copy link
Contributor

wewhite commented Jun 22, 2023

Ok, I had it patched in my development versions, that is why it worked for me.
The fix is this commit: Plugin Tables: Do not create sort/order button when column sort is disabled

This was merged into WET Release Release v4.0.62.

@DBlaisAsc
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants