Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema and generated types for anchor cells. #124

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Conversation

lthibault
Copy link
Collaborator

This PR is the first part of an effort to extend #108 (basic Anchor implementation) with the ability to load/store values from an anchor path. It may be helpful for reviewers to quickly re-read #108.

The present PR adds a cell() method to the Anchor schema. This method returns a set of capabilities that serve as an access-controlled interface to the values stored in an anchor. I recommend reading the docstrings in anchor.capnp, and encourage reviewers to flag any lingering uncertainties.

The next PR will focus on the actual implementation of the cell interfaces, as well as updating the Anchor's refcounting logic to track the presence of stored values.

@mikelsr I'm tagging you as the primary reviewer as per our conversation on Friday. This will hopefully help you form an understanding of the anchor API, and inform our future work on Wetware demos.

cc @aratz-lasa @ayazabbas Your feedback is, as always, most welcome :)

@lthibault lthibault added the enhancement New feature or request label Jul 3, 2023
@lthibault lthibault added this to the 0.1.0 Public Beta Release milestone Jul 3, 2023
@lthibault lthibault requested a review from mikelsr July 3, 2023 14:13
@lthibault lthibault self-assigned this Jul 3, 2023
@lthibault
Copy link
Collaborator Author

@mikelsr Note that for simplicity's sake, I am opening this PR against the master branch, so we'll likely want to rebase v0.1.0 against master at some point. No need to do it right now, though, especially since I expect to put in a small clean-up effort before we merge.

api/anchor.capnp Show resolved Hide resolved
api/anchor.capnp Show resolved Hide resolved
api/anchor.capnp Outdated Show resolved Hide resolved
api/anchor.capnp Outdated Show resolved Hide resolved
@mikelsr
Copy link
Contributor

mikelsr commented Jul 6, 2023

Thanks for the changes :)

@lthibault lthibault merged commit 29af282 into master Jul 7, 2023
1 check passed
@lthibault lthibault deleted the feat/cell-schema branch July 7, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants