城市选择组件相关优化 #174
Closed
城市选择组件相关优化 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n7best
reviewed
Dec 30, 2016
| this.handleClose( ()=> { if(this.props.onChange) this.props.onChange(this.state.selected, this) } ) | ||
| this.handleClose( ()=> { | ||
| // choose default city | ||
| const chooseDefault = this.state.selected.find((item) => item != 0) === undefined; |
There was a problem hiding this comment.
感觉这个item != 0在 普通picker使用情况下 可能不是默认的值
picker最好不能受限于citypicker
|
Close due to inactive, will be add to future updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.