Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ESLint version & rules, then fix code across project, and fixed #212 #213

Merged
merged 8 commits into from
Mar 13, 2017

Commits on Mar 11, 2017

  1. Set .eslintrc to show lint warning/error

    The reason is that starting from version 1.0 of ESLint, all linting
    rules are turned off by default.
    haxpor committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    7b56930 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'fix_eslint'

    haxpor committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    e9be6e4 View commit details
    Browse the repository at this point in the history
  3. Update ESLint v. and its rules and fix warnings/errors across project

    - already tested via `npm run test` and all tests passed.
    - most of code fixed across the project are about semi colon, space
      after if/else if/else/for statement, removed newline at the end of file, a few dangerous code statement fixed, and a few that is not needed.
    - ESlint is updated to version 3.17.1. The project has used version
      1.x.x. This should be better.
    - ESLint's rules are updated to be more stricted but not too strict. See
      it in .eslintrc.
    haxpor committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    08e50f4 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'update_eslint'

    haxpor committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    96c831b View commit details
    Browse the repository at this point in the history
  5. Fix issue 212

    haxpor committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    d38636c View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2017

  1. Merge branch 'fix_#212'

    haxpor committed Mar 12, 2017
    Configuration menu
    Copy the full SHA
    a5757f2 View commit details
    Browse the repository at this point in the history
  2. Review and fix weui#212 with better approach

    - provided 'component' property to be able to replace component instead
      of using react-router, more flexible
    
      example of setting from Grid's data from code to use react-router url is as follows
    
      const data = [
      {
        icon: <img src="./image.png" alt="image icon"/>,
        label: 'Label',
        component: function(props) {
            const { children, ...others } = props;
            return <Link to="/router-url" {...others}> { children } </Link>;
        }
      },
      ]
    haxpor committed Mar 12, 2017
    Configuration menu
    Copy the full SHA
    b0ba6d1 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'fix_#212'

    haxpor committed Mar 12, 2017
    Configuration menu
    Copy the full SHA
    ec45e68 View commit details
    Browse the repository at this point in the history