-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/weui beta #323
Feature/weui beta #323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
重点
不在行内提建议了哈,因为有一些代码需要新增,不在已修改的文件集合中。
-
CI Fail
CI 失败主要是因为执行单元测试 使用的是 mocha,在升级 babel 版本后,原本的babel-core/register
依赖被删除了,如需保持 CI 正常运行(继续使用mocha),需要做以下工作:
1.1. 安装依赖@babel/register
1.2. 更新项目中的test/mocha.opts
,将旧版的 babel register 更新为--require @babel/core
和--require @babel/register
两行
1.3.yarn coverage
所执行的nyc
require 部分也要修改,babel-core/register
参考 1.2 内容进行修改 -
Webpack
webpack升级到4之后,部分 production 配置需要修改,这里根据构建时提示修改去除 warning -
Rollup build script
- 移除部分调试用的
console.log
- 执行
yarn build
并没有很好的把 production 相关配置传递进去,构建出来少了.min
版本的内容 - 这里的修改请对比前几个版本的构建产物目录,可在 https://cdn.unix.bio/?q=react-weui&npm=1 中对比 1.1.x ~ 1.2.3 之间的产物发布目录
其他
- eslint 样式问题,
npm scripts - lint
的部分,应当包含新增的components/**/*.ts tsx
路径 - 修复新增的
ts/tsx
文件带来的风格问题,如双引号->单引号等
… into feature/weui_beta
… into feature/weui_beta
simplify bin command in node_modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
update version 2.0
support button