Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/weui beta #323

Merged
merged 11 commits into from
Aug 6, 2020
Merged

Feature/weui beta #323

merged 11 commits into from
Aug 6, 2020

Conversation

z2014
Copy link
Collaborator

@z2014 z2014 commented Aug 2, 2020

update version 2.0

  1. update components button support ts
  2. update webpack 4
  3. update rollup plugin
    support button

Copy link
Collaborator

@aquariuslt aquariuslt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

重点

不在行内提建议了哈,因为有一些代码需要新增,不在已修改的文件集合中。

  1. CI Fail
    CI 失败主要是因为执行单元测试 使用的是 mocha,在升级 babel 版本后,原本的 babel-core/register 依赖被删除了,如需保持 CI 正常运行(继续使用mocha),需要做以下工作:
    1.1. 安装依赖 @babel/register
    1.2. 更新项目中的 test/mocha.opts ,将旧版的 babel register 更新为 --require @babel/core--require @babel/register 两行
    1.3. yarn coverage 所执行的 nyc require 部分也要修改, babel-core/register 参考 1.2 内容进行修改

  2. Webpack
    webpack升级到4之后,部分 production 配置需要修改,这里根据构建时提示修改去除 warning

  3. Rollup build script

  • 移除部分调试用的 console.log
  • 执行 yarn build 并没有很好的把 production 相关配置传递进去,构建出来少了 .min版本的内容
  • 这里的修改请对比前几个版本的构建产物目录,可在 https://cdn.unix.bio/?q=react-weui&npm=1 中对比 1.1.x ~ 1.2.3 之间的产物发布目录

其他

  1. eslint 样式问题,npm scripts - lint 的部分,应当包含新增的 components/**/*.ts tsx 路径
  2. 修复新增的 ts/tsx 文件带来的风格问题,如双引号->单引号等

@coveralls
Copy link

coveralls commented Aug 3, 2020

Coverage Status

Coverage decreased (-0.1%) to 81.236% when pulling 2097f76 on z2014:feature/weui_beta into 494113a on weui:feature/weui_v2_beta.

example/index.html Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
webpack.config.doc.js Outdated Show resolved Hide resolved
webpack.config.js Outdated Show resolved Hide resolved
@z2014 z2014 added this to Review in progress in 2.0 Aug 6, 2020
@z2014 z2014 moved this from Review in progress to In progress in 2.0 Aug 6, 2020
@z2014 z2014 moved this from In progress to Review in progress in 2.0 Aug 6, 2020
@z2014 z2014 removed this from Review in progress in 2.0 Aug 6, 2020
Copy link
Collaborator

@aquariuslt aquariuslt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aquariuslt aquariuslt added this to In progress in 2.0 via automation Aug 6, 2020
@z2014 z2014 merged commit b9ab318 into weui:feature/weui_v2_beta Aug 6, 2020
2.0 automation moved this from In progress to Done Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants