Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra space in formatAbi return type #173

Closed
3 tasks done
roninjin10 opened this issue Jul 20, 2023 · 4 comments · Fixed by #176
Closed
3 tasks done

Extra space in formatAbi return type #173

roninjin10 opened this issue Jul 20, 2023 · 4 comments · Fixed by #176
Labels
good first issue Good for newcomers

Comments

@roninjin10
Copy link
Sponsor

Describe the bug

Trying to write a test that involves asserting the correct types are emited by Evmts, I noticed a mismatch between formatAbi and abitype. Abitype has an extra space in the parameters. Not a big deal in practice but a little janky looking and for me it's blocking me asserting that Evmts LSP is emitting right type here

Link to Minimal Reproducible Example

https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgM2iAhjAggI2HAXxSghDgHJ08YBPMAU3IChRJZE4B3KYGegMWAAbegGUaAOwDGhYqQrIAzsyZSIExfHpQpAJgAMufAF44AbSYBIBFcsAiNRpjoJMOwC44MKAFd6AGls7YAkwHxhFD3MAXUDLewl0EHoou0Tkuzj7CHCwiKiLeOtbeLSklM87TJL7WgZUzR4JAHM7EoJbWKCwdBoqESjkdCFFAKDNTHoAWXCqYV4aVIA3YHpOatK6irg7ZB9pGGB1NssCOJtSxwnXQeHRrODQ8MjPQviLorKMyoB9RQYJAATbQbT5bVLoQGAqD0RSRdpZYpFBLlVI-JbDPygzZ0bZ2HwhGC6ACsADYTvEOvEuqV0nj0GAwCQlikHjkYHkXuYSh9aajKtjarjUjgIBAhBTTp0Hj0+jgBp4hiMxqUJnwZs48EIFqkJOpZf1WUFwZU9gcjhITmcrB8HOprm5PN4-A8QpyCjSUd8djAIM4hKIfIyhIs2blngUeTUvnjBXYTTsCa4SeT2tLur1DbdlQ81dNZlqdZUVmtQfHhab9lJDscrNakfYrs4boq7ir7G6I68o8iY2jkCQQHGE3ZIdDYfCivX3tG6WjfcOKzsxzC4ZLpw2+d67OjMUbeyOk0Syev01u8d4XIpkNp+IOy+z3d2iryvbHEUL6pVReLT9SZZm8rbEq9zjM46oFvMtC6vqgEDA8I5mtWFpWucQRNi4jpeL47aPE+MQPHOlTAlIoB3A+4b5M+M69kROyLl+iaEgAHH+lienYBpAdmoGquB+aalBizFqs6wIUuuxVjWlp1mhlz2s2WHOrhnZUdyL6zvyOw-BAnASCCH7loxo5Qquk6Umeb4isMLhSPQADyyAURyXbqTRnx0XYOA2dI+5ghJR4pmxHFcQqKBtrm-EanM2rQSJpbicZSHSahNroQpmFRMprpPGpZgcZ5ig0CAooSmGLl5T2HlaVUhkjo0IStGm-4ZnKYUgbhebRYWcU7CWYnGhJyUobJaXyU4mWtjmQSqVybyblZvwLnVEkrhO66Iq+fa-BiQhYitxmBSezXsYRNWXhoN5QM5+HzVtnkMXiP4SidIVwcBEVgZM3VCTBoTvWWiFSSNpxyY2GUtthLozblc1VeeaK6fp10HfSpnrQi8OLdp-z0ECBnRiOa1rq9Z3bsMQi6bZfl2I+rl3Zp26PakR2plOlmcQDU28fYXWQbFwl9aJgNDcDtag2N9ihds2VfRBgkC6k0si0lFPeVIADWqUNqOeoSMVORch1OW3VjjzAgAHvQgJZThhmeUjBMHqt6Mk1Om3RiElvW7b0O0TVuP4yjhMu+ObuUh7vZe-QVs29z7YI8We7M5UrPBWTeJYIyzLDCreL0CyNyjTrLjqAbPhG59pSzZGGlR-jse+wn2O7PeqMQq75kS3XnzR43Tp24zF4QCny6dxtZt9z78f2zVu37SHh2EkFpNBJ5AAqUBXldeepAXeNuHWTDRHA6CKHATZMKoCkoGgmB8ICRhwKYqBQBg2B4AAFNoeiGHgACUQA

Steps To Reproduce

Use formatAbi and notice extra spaces when you hover
image

Package Version

0.9.3

TypeScript Version

5.1.6

Anything else?

No response

Validations

@roninjin10 roninjin10 changed the title Extra space in abitype Extra space in formatAbi return type Jul 20, 2023
@tmm
Copy link
Member

tmm commented Jul 20, 2023

PR welcome

@tmm tmm added the good first issue Good for newcomers label Jul 20, 2023
@roninjin10
Copy link
Sponsor Author

Won't have time to get to this til August but if still open I can definitely take this one on likely an easy fix

tmm added a commit that referenced this issue Jul 21, 2023
@tmm tmm mentioned this issue Jul 21, 2023
3 tasks
@roninjin10
Copy link
Sponsor Author

Holy closed before vacation started so I can use this right away! Ya'll are the goats!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest ABIType version. If you have any other comments you can create a new discussion.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants