Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos #212

Merged
merged 3 commits into from
Nov 28, 2023
Merged

fix: typos #212

merged 3 commits into from
Nov 28, 2023

Conversation

shuoer86
Copy link
Contributor

@shuoer86 shuoer86 commented Nov 26, 2023

PR-Codex overview

This PR focuses on fixing typos in the abitype package.

Detailed summary:

  • Fixed typos in error messages for InvalidAbiItemError, InvalidAbiParameterError, InvalidAbiParametersError, InvalidParameterError, InvalidFunctionModifierError, and InvalidAbiTypeParameterError.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 26, 2023

🦋 Changeset detected

Latest commit: bbe123b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
abitype Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abitype ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 2:52pm

Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a patch changeset with pnpm changeset?

@shuoer86
Copy link
Contributor Author

@tmm Thanks for your review. I have added changeset.

@Raiden1411
Copy link
Collaborator

Thanks for the PR!
Would you mind also updating the typos here:

new InvalidAbiItemError({ signature: 'addres' }),

new InvalidAbiParameterError({ param: 'addres owner' }),

new InvalidAbiParametersError({ params: 'addres owner' }),


@shuoer86
Copy link
Contributor Author

@Raiden1411 updated, thanks for your review.

@Raiden1411 Raiden1411 merged commit 1a1a114 into wevm:main Nov 28, 2023
12 of 13 checks passed
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants