Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes regex for fallback signatures #229

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Fixes regex for fallback signatures #229

merged 1 commit into from
Mar 2, 2024

Conversation

kyscott18
Copy link
Contributor

@kyscott18 kyscott18 commented Mar 2, 2024

Description

Bug fix for fallback signatures. Previously, it was not consistent with the docs or types.

Additional Information

Before submitting this issue, please make sure you do the following.

  • Read the contributing guide
  • Added documentation related to the changes made.
  • Added or updated tests (and snapshots) related to the changes made.

PR-Codex overview

The focus of this PR is to fix the regex for fallback signatures in the abitype package.

Detailed summary

  • Updated regex for fallback signatures to include external and optional payable state mutability.
  • Added tests to cover the new regex pattern.
  • Improved accuracy in identifying fallback signatures.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Mar 2, 2024

🦋 Changeset detected

Latest commit: bf44fec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
abitype Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abitype ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2024 10:20pm

Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (6b2979f) to head (bf44fec).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   99.83%   99.85%   +0.01%     
==========================================
  Files          26       26              
  Lines        6082     6083       +1     
  Branches      195      195              
==========================================
+ Hits         6072     6074       +2     
  Misses          8        8              
+ Partials        2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmm tmm merged commit a9300dd into wevm:main Mar 2, 2024
15 checks passed
@github-actions github-actions bot mentioned this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants